jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/360904 )
Change subject: Revert "mw.action.edit: Restore modifier keys for accesskey in
tooltip for summary field"
......................................................................
Revert "mw.action.edit: Restore modifier keys for accesskey in tooltip for
summary field"
No longer needed after changes from T168408.
This reverts commit 0269ae0fe57f5192743e99ccd67970db989b542d.
Bug: T168408
Change-Id: I50c24a9bada19a0e7d3a009c9afec073f6ffa357
---
M resources/Resources.php
M resources/src/mediawiki.action/mediawiki.action.edit.js
2 files changed, 0 insertions(+), 5 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/resources/Resources.php b/resources/Resources.php
index 82f285e..45a90d1 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1423,7 +1423,6 @@
'styles' =>
'resources/src/mediawiki.action/mediawiki.action.edit.css',
'dependencies' => [
'mediawiki.action.edit.styles',
- 'jquery.accessKeyLabel',
'jquery.textSelection',
'jquery.byteLimit',
'mediawiki.widgets.visibleByteLimit',
diff --git a/resources/src/mediawiki.action/mediawiki.action.edit.js
b/resources/src/mediawiki.action/mediawiki.action.edit.js
index 5b81017..5a9ed7e 100644
--- a/resources/src/mediawiki.action/mediawiki.action.edit.js
+++ b/resources/src/mediawiki.action/mediawiki.action.edit.js
@@ -23,10 +23,6 @@
mw.loader.using( 'oojs-ui-core' ).then( function () {
var wpSummary = OO.ui.infuse( $(
'#wpSummaryWidget' ) );
- // Restore appropriate modifier keys for the
accesskey in the 'title' attribute
- // TODO: This should be an OOjs UI feature, or
somehow happen automatically after infusing.
- wpSummary.$input.updateTooltipAccessKeys();
-
// Show a byte-counter to users with how many
bytes are left for their edit summary.
// TODO: This looks a bit weird, as there is no
unit in the UI, just numbers; showing
// 'bytes' confused users in testing, and
showing 'chars' would be a lie. See T42035.
--
To view, visit https://gerrit.wikimedia.org/r/360904
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50c24a9bada19a0e7d3a009c9afec073f6ffa357
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
