Daniel Kinzler has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369846 )
Change subject: Hot fix for InjectRCRecordsJob: disable coalescing ...................................................................... Hot fix for InjectRCRecordsJob: disable coalescing Bug: T172320 Change-Id: I039b815395c56bc522ec34fd60230a0997f6c27d --- M client/includes/Changes/ChangeHandler.php M client/includes/Changes/InjectRCRecordsJob.php 2 files changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/46/369846/1 diff --git a/client/includes/Changes/ChangeHandler.php b/client/includes/Changes/ChangeHandler.php index 884c30e..a5a5f1f 100644 --- a/client/includes/Changes/ChangeHandler.php +++ b/client/includes/Changes/ChangeHandler.php @@ -123,7 +123,8 @@ * @param EntityChange[] $changes */ public function handleChanges( array $changes ) { - $changes = $this->changeRunCoalescer->transformChangeList( $changes ); + // FIXME: Commented out as a HOT FIX for T172320 + // $changes = $this->changeRunCoalescer->transformChangeList( $changes ); if ( !Hooks::run( 'WikibaseHandleChanges', [ $changes ] ) ) { return; diff --git a/client/includes/Changes/InjectRCRecordsJob.php b/client/includes/Changes/InjectRCRecordsJob.php index 54c4781..20c361e 100644 --- a/client/includes/Changes/InjectRCRecordsJob.php +++ b/client/includes/Changes/InjectRCRecordsJob.php @@ -2,6 +2,7 @@ namespace Wikibase\Client\Changes; +use InvalidArgumentException; use Job; use JobSpecification; use Liuggio\StatsdClient\Factory\StatsdDataFactoryInterface; @@ -75,6 +76,10 @@ * @return JobSpecification */ public static function makeJobSpecification( array $titles, EntityChange $change ) { + if ( $change->getId() === null ) { + throw new InvalidArgumentException( 'The given Change does not have an ID defined' ); + } + $pages = []; foreach ( $titles as $t ) { @@ -91,7 +96,6 @@ 'wikibase-InjectRCRecords', $params ); - } /** -- To view, visit https://gerrit.wikimedia.org/r/369846 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I039b815395c56bc522ec34fd60230a0997f6c27d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler <daniel.kinz...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits