Lucas Werkmeister (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/369917 )
Change subject: Migrate OneOfChecker tests to statement parameters
......................................................................
Migrate OneOfChecker tests to statement parameters
The tests use the itemsParameter() method introduced in the previous
commit.
Bug: T172378
Change-Id: I3492802a477896f686ca3bf1c235f43315c2f712
---
M tests/phpunit/Checker/OneOfChecker/OneOfCheckerTest.php
1 file changed, 6 insertions(+), 6 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityConstraints
refs/changes/17/369917/1
diff --git a/tests/phpunit/Checker/OneOfChecker/OneOfCheckerTest.php
b/tests/phpunit/Checker/OneOfChecker/OneOfCheckerTest.php
index 85d2b59..511da36 100644
--- a/tests/phpunit/Checker/OneOfChecker/OneOfCheckerTest.php
+++ b/tests/phpunit/Checker/OneOfChecker/OneOfCheckerTest.php
@@ -55,33 +55,33 @@
$statementIn = new Statement( new PropertyValueSnak( new
PropertyId( 'P123' ), $valueIn ) );
$statementNotIn = new Statement( new PropertyValueSnak( new
PropertyId( 'P123' ), $valueNotIn ) );
- $values = 'Q1,Q2,Q3';
-
$result = $this->oneOfChecker->checkConstraint(
$statementIn,
- $this->getConstraintMock( [ 'item' => $values ] ),
+ $this->getConstraintMock( $this->itemsParameter( [
'Q1', 'Q2', 'Q3' ] ) ),
$this->getEntity()
);
+
$this->assertCompliance( $result );
$result = $this->oneOfChecker->checkConstraint(
$statementNotIn,
- $this->getConstraintMock( [ 'item' => $values ] ),
+ $this->getConstraintMock( $this->itemsParameter( [
'Q1', 'Q2', 'Q3' ] ) ),
$this->getEntity()
);
+
$this->assertViolation( $result,
'wbqc-violation-message-one-of' );
}
public function testOneOfConstraintWrongType() {
$value = new StringValue( 'Q1' );
$statement = new Statement( new PropertyValueSnak( new
PropertyId( 'P123' ), $value ) );
- $values = 'Q1,Q2,Q3';
$result = $this->oneOfChecker->checkConstraint(
$statement,
- $this->getConstraintMock( [ 'item' => $values ] ),
+ $this->getConstraintMock( $this->itemsParameter( [
'Q1', 'Q2', 'Q3' ] ) ),
$this->getEntity()
);
+
$this->assertViolation( $result,
'wbqc-violation-message-one-of' );
}
--
To view, visit https://gerrit.wikimedia.org/r/369917
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3492802a477896f686ca3bf1c235f43315c2f712
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <lucas.werkmeis...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
