Kaldari has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370113 )
Change subject: Only show popup if CodeMirror button exists
......................................................................
Only show popup if CodeMirror button exists
Bug: T170609
Change-Id: Ibe9aa1b7ffce2e7813aa9aa2ab45f349d8ad2082
(cherry picked from commit 28a9dd7facd310a9c10d6e467f38b000c6edbe0b)
---
M resources/ext.CodeMirror.js
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeMirror
refs/changes/13/370113/1
diff --git a/resources/ext.CodeMirror.js b/resources/ext.CodeMirror.js
index 0541a2a..5a1ad48 100644
--- a/resources/ext.CodeMirror.js
+++ b/resources/ext.CodeMirror.js
@@ -403,6 +403,11 @@
function handlePopup() {
var yesButton, noButton, $title, $content, popup;
+ // If CodeMirror button doesn't exist, don't show popup
+ if ( !$( '#mw-editbutton-codemirror' ).length ) {
+ return;
+ }
+
// If popup has previously been dismissed, don't show again.
if ( mw.storage.get( 'codemirror-try-popup' ) ) {
return;
--
To view, visit https://gerrit.wikimedia.org/r/370113
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe9aa1b7ffce2e7813aa9aa2ab45f349d8ad2082
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeMirror
Gerrit-Branch: wmf/1.30.0-wmf.12
Gerrit-Owner: Kaldari <rkald...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
