VolkerE has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370347 )
Change subject: Align code comment references to Phabricator tasks
......................................................................
Align code comment references to Phabricator tasks
Also updating reference from Bugzilla.
Change-Id: Ibb3b611afa228cd62b0185098e51d789f2e2912b
---
M src/Element.js
M src/WindowManager.js
M src/layouts/BookletLayout.js
M src/layouts/IndexLayout.js
M src/layouts/TabPanelLayout.js
M src/mixins/ClippableElement.js
M src/styles/common.less
M src/themes/apex/elements.less
M src/themes/wikimediaui/common.less
M src/themes/wikimediaui/widgets.less
M src/widgets/InputWidget.js
M src/widgets/TextInputWidget.js
12 files changed, 29 insertions(+), 29 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/47/370347/1
diff --git a/src/Element.js b/src/Element.js
index 5f61429..e4c7ff3 100644
--- a/src/Element.js
+++ b/src/Element.js
@@ -103,7 +103,7 @@
OO.ui.Element.static.infuse = function ( idOrNode ) {
var obj = OO.ui.Element.static.unsafeInfuse( idOrNode, false );
// Verify that the type matches up.
- // FIXME: uncomment after T89721 is fixed (see T90929)
+ // FIXME: uncomment after T89721 is fixed, see T90929.
/*
if ( !( obj instanceof this['class'] ) ) {
throw new Error( 'Infusion type mismatch!' );
@@ -240,7 +240,7 @@
if ( $elem[ 0 ] !== obj.$element[ 0 ] ) {
$elem.replaceWith( obj.$element );
// This element is now gone from the DOM, but if anyone
is holding a reference to it,
- // let's allow them to OO.ui.infuse() it and do what
they expect (T105828).
+ // let's allow them to OO.ui.infuse() it and do what
they expect, see T105828.
// Do not use jQuery.data(), as using it on detached
nodes leaks memory in 1.x line by design.
$elem[ 0 ].oouiInfused = obj.$element;
}
diff --git a/src/WindowManager.js b/src/WindowManager.js
index 1a256d3..62ebb4d 100644
--- a/src/WindowManager.js
+++ b/src/WindowManager.js
@@ -341,7 +341,7 @@
* @return {OO.ui.WindowInstance|jQuery.Promise} A lifecycle object
representing this particular
* opening of the window. For backwards-compatibility, then object is also a
Thenable that is resolved
* when the window is done opening, with nested promise for when closing
starts. This behaviour
- * is deprecated and is not compatible with jQuery 3 (T163510).
+ * is deprecated and is not compatible with jQuery 3. See T163510.
* @fires opening
*/
OO.ui.WindowManager.prototype.openWindow = function ( win, data, lifecycle,
compatOpening ) {
@@ -356,7 +356,7 @@
compatOpening = compatOpening || $.Deferred();
// Turn lifecycle into a Thenable for backwards-compatibility with
- // the deprecated nested-promise behaviour (T163510).
+ // the deprecated nested-promise behaviour, see T163510.
[ 'state', 'always', 'catch', 'pipe', 'then', 'promise', 'progress',
'done', 'fail' ]
.forEach( function ( method ) {
lifecycle[ method ] = function () {
@@ -444,7 +444,7 @@
* @param {Object} [data] Window closing data
* @return {OO.ui.WindowInstance|jQuery.Promise} A lifecycle object
representing this particular
* opening of the window. For backwards-compatibility, the object is also a
Thenable that is resolved
- * when the window is done closing (T163510).
+ * when the window is done closing, see T163510.
* @fires closing
*/
OO.ui.WindowManager.prototype.closeWindow = function ( win, data ) {
@@ -482,7 +482,7 @@
}
// Turn lifecycle into a Thenable for backwards-compatibility with
- // the deprecated nested-promise behaviour (T163510).
+ // the deprecated nested-promise behaviour, see T163510.
[ 'state', 'always', 'catch', 'pipe', 'then', 'promise', 'progress',
'done', 'fail' ]
.forEach( function ( method ) {
lifecycle[ method ] = function () {
diff --git a/src/layouts/BookletLayout.js b/src/layouts/BookletLayout.js
index c1999c9..a2c4638 100644
--- a/src/layouts/BookletLayout.js
+++ b/src/layouts/BookletLayout.js
@@ -281,8 +281,8 @@
this.outlineVisible = show;
this.toggleMenu( show );
if ( show && this.editable ) {
- // HACK: When the sidebar stops animating, kill dumb
scrollbars (T161798). Only necessary when
- // outline controls are present, The delay matches
transition on `.oo-ui-menuLayout-menu`.
+ // HACK: Kill dumb scrollbars when the sidebar stops
animating, see T161798. Only necessary when
+ // outline controls are present, delay matches
transition on `.oo-ui-menuLayout-menu`.
setTimeout( function () {
OO.ui.Element.static.reconsiderScrollbars(
booklet.outlinePanel.$element[ 0 ] );
}, 200 );
diff --git a/src/layouts/IndexLayout.js b/src/layouts/IndexLayout.js
index f46c978..e15957a 100644
--- a/src/layouts/IndexLayout.js
+++ b/src/layouts/IndexLayout.js
@@ -54,11 +54,11 @@
configurable: true,
enumerable: true,
get: function () {
- OO.ui.warnDeprecation( 'IndexLayout\'s currentCardName
property is deprecated. Use currentTabPanelName instead. See T155152' );
+ OO.ui.warnDeprecation( 'IndexLayout\'s currentCardName
property is deprecated. Use currentTabPanelName instead. See T155152.' );
return this.currentTabPanelName;
},
set: function ( value ) {
- OO.ui.warnDeprecation( 'IndexLayout\'s currentCardName
property is deprecated. Use currentTabPanelName instead. See T155152' );
+ OO.ui.warnDeprecation( 'IndexLayout\'s currentCardName
property is deprecated. Use currentTabPanelName instead. See T155152.' );
this.currentTabPanelName = value;
}
} );
@@ -68,11 +68,11 @@
configurable: true,
enumerable: true,
get: function () {
- OO.ui.warnDeprecation( 'IndexLayout\'s cards property
is deprecated. Use tabPanels instead. See T155152' );
+ OO.ui.warnDeprecation( 'IndexLayout\'s cards property
is deprecated. Use tabPanels instead. See T155152.' );
return this.tabPanels;
},
set: function ( value ) {
- OO.ui.warnDeprecation( 'IndexLayout\'s cards property
is deprecated. Use tabPanels instead. See T155152' );
+ OO.ui.warnDeprecation( 'IndexLayout\'s cards property
is deprecated. Use tabPanels instead. See T155152.' );
this.tabPanels = value;
}
} );
@@ -265,7 +265,7 @@
* @deprecated since v0.21.3, use `getClosestTabPanel` instead
*/
OO.ui.IndexLayout.prototype.getClosestCard = function ( tabPanel ) {
- OO.ui.warnDeprecation( 'IndexLayout\'s getClosestCard method is
deprecated. Use getClosestTabPanel instead. See T155152' );
+ OO.ui.warnDeprecation( 'IndexLayout\'s getClosestCard method is
deprecated. Use getClosestTabPanel instead. See T155152.' );
return this.getClosestTabPanel( tabPanel );
};
@@ -296,7 +296,7 @@
* @deprecated since v0.21.3, use `getTabPanel` instead
*/
OO.ui.IndexLayout.prototype.getCard = function ( name ) {
- OO.ui.warnDeprecation( 'IndexLayout\'s getCard method is deprecated.
Use getTabPanel instead. See T155152' );
+ OO.ui.warnDeprecation( 'IndexLayout\'s getCard method is deprecated.
Use getTabPanel instead. See T155152.' );
return this.getTabPanel( name );
};
@@ -317,7 +317,7 @@
* @deprecated since v0.21.3, use `getCurrentTabPanel` instead
*/
OO.ui.IndexLayout.prototype.getCurrentCard = function () {
- OO.ui.warnDeprecation( 'IndexLayout\'s getCurrentCard method is
deprecated. Use getCurrentTabPanel instead. See T155152' );
+ OO.ui.warnDeprecation( 'IndexLayout\'s getCurrentCard method is
deprecated. Use getCurrentTabPanel instead. See T155152.' );
return this.getCurrentTabPanel();
};
@@ -337,7 +337,7 @@
* @deprecated since v0.21.3, use `getCurrentTabPanelName` instead
*/
OO.ui.IndexLayout.prototype.getCurrentCardName = function () {
- OO.ui.warnDeprecation( 'IndexLayout\'s getCurrentCardName method is
deprecated. Use getCurrentTabPanelName instead. See T155152' );
+ OO.ui.warnDeprecation( 'IndexLayout\'s getCurrentCardName method is
deprecated. Use getCurrentTabPanelName instead. See T155152.' );
return this.getCurrentTabPanelName();
};
@@ -409,7 +409,7 @@
* @deprecated since v0.21.3, use `addTabPanels` instead
*/
OO.ui.IndexLayout.prototype.addCards = function ( tabPanels, index ) {
- OO.ui.warnDeprecation( 'IndexLayout\'s addCards method is deprecated.
Use addTabPanels instead. See T155152' );
+ OO.ui.warnDeprecation( 'IndexLayout\'s addCards method is deprecated.
Use addTabPanels instead. See T155152.' );
return this.addTabPanels( tabPanels, index );
};
diff --git a/src/layouts/TabPanelLayout.js b/src/layouts/TabPanelLayout.js
index cdb81fd..0824886 100644
--- a/src/layouts/TabPanelLayout.js
+++ b/src/layouts/TabPanelLayout.js
@@ -154,7 +154,7 @@
* @deprecated since v0.21.3
*/
OO.ui.CardLayout = function OoUiCardLayout() {
- OO.ui.warnDeprecation( 'CardLayout has been renamed to TabPanel layout.
Use that instead. See T155152' );
+ OO.ui.warnDeprecation( 'CardLayout has been renamed to TabPanel layout.
Use that instead. See T155152.' );
// Parent constructor
OO.ui.CardLayout.parent.apply( this, arguments );
};
diff --git a/src/mixins/ClippableElement.js b/src/mixins/ClippableElement.js
index 035021b..9108348 100644
--- a/src/mixins/ClippableElement.js
+++ b/src/mixins/ClippableElement.js
@@ -246,7 +246,7 @@
clipHeight = allotedHeight < naturalHeight;
if ( clipWidth ) {
- // The order matters here. If overflow is not set first, Chrome
displays bogus scrollbars. (T157672)
+ // The order matters here. If overflow is not set first, Chrome
displays bogus scrollbars. See T157672.
// Forcing a reflow is a smaller workaround than calling
reconsiderScrollbars() for this case.
this.$clippable.css( 'overflowX', 'scroll' );
void this.$clippable[ 0 ].offsetHeight; // Force reflow
@@ -262,7 +262,7 @@
} );
}
if ( clipHeight ) {
- // The order matters here. If overflow is not set first, Chrome
displays bogus scrollbars. (T157672)
+ // The order matters here. If overflow is not set first, Chrome
displays bogus scrollbars. See T157672.
// Forcing a reflow is a smaller workaround than calling
reconsiderScrollbars() for this case.
this.$clippable.css( 'overflowY', 'scroll' );
void this.$clippable[ 0 ].offsetHeight; // Force reflow
diff --git a/src/styles/common.less b/src/styles/common.less
index f1d43bf..d188333 100644
--- a/src/styles/common.less
+++ b/src/styles/common.less
@@ -73,7 +73,7 @@
// `.oo-ui-box-shadow()` in contrast to `.oo-ui-box-sizing` unprefixed only
// for circumventing performance issues and due to failing gracefully in
// Safari 3.1-5.0, iOS 3.2-4.3, Android 2.1-3.0
-// @see https://phabricator.wikimedia.org/T125925
+// See T125925
.oo-ui-vertical-gradient( @start: #eee, @stop: #fff ) {
background-color: average( @start, @stop );
diff --git a/src/themes/apex/elements.less b/src/themes/apex/elements.less
index df657f6..639a7d1 100644
--- a/src/themes/apex/elements.less
+++ b/src/themes/apex/elements.less
@@ -37,7 +37,7 @@
&-frameless {
> .oo-ui-buttonElement-button {
// Don't animate `.oo-ui-iconElement-icon` `opacity`
for now,
- // causes wiggling in Chrome (bug 63020)
+ // causes wiggling in Chrome, see T65020
// `.oo-ui-transition( opacity @medium-ease );`
&:hover,
diff --git a/src/themes/wikimediaui/common.less
b/src/themes/wikimediaui/common.less
index c8a6c2a..8145470 100644
--- a/src/themes/wikimediaui/common.less
+++ b/src/themes/wikimediaui/common.less
@@ -190,7 +190,7 @@
// Workaround for Safari 8 bug. Combining a selector like
`input[type="checkbox"]:checked + span`
// with transition on background-size, background-color, and a single
background-image using SVG
-// causes the selector to sometimes not be applied. (T89309)
+// causes the selector to sometimes not be applied, see T89309
//
// * Syntax mimics the core mixin .oo-ui-background-image-svg().
// * No-op in distributions other than 'vector'.
diff --git a/src/themes/wikimediaui/widgets.less
b/src/themes/wikimediaui/widgets.less
index 46403ac..64160af 100644
--- a/src/themes/wikimediaui/widgets.less
+++ b/src/themes/wikimediaui/widgets.less
@@ -328,7 +328,7 @@
line-height: @size-input-binary;
// Prevent the fake span from jumping to the next line of text
white-space: nowrap;
- // Support: Firefox weird rendering issue needs this workaround
(T171022)
+ // Support: Firefox weird rendering issue needs this workaround, see
T171022
display: inline-block;
* {
@@ -339,7 +339,7 @@
// `<input type=checkbox>` element is visually replaced by `span` that
follows
[type='checkbox'] {
position: relative;
- // Support: Firefox mobile to override user-agent stylesheet
(T73750)
+ // Support: Firefox mobile to override user-agent stylesheet,
see T73750
max-width: none;
// Ensure the invisible input takes up the required width
width: @size-input-binary;
@@ -1159,7 +1159,7 @@
line-height: @size-input-binary;
// Prevent the fake span from jumping to the next line of text
white-space: nowrap;
- // Support: Firefox weird rendering issue needs this workaround
(T171022)
+ // Support: Firefox weird rendering issue needs this workaround, see
T171022
display: inline-block;
* {
@@ -1170,7 +1170,7 @@
// `<input type=radio>` element is visually replaced by `span` that
follows
[type='radio'] {
position: relative;
- // Support: Firefox mobile to override user-agent stylesheet
(T73750)
+ // Support: Firefox mobile to override user-agent stylesheet,
see T73750
max-width: none;
// Ensure the invisible input takes up the required width
width: @size-input-binary;
diff --git a/src/widgets/InputWidget.js b/src/widgets/InputWidget.js
index 12dc4f3..a3b8f09 100644
--- a/src/widgets/InputWidget.js
+++ b/src/widgets/InputWidget.js
@@ -77,7 +77,7 @@
*/
OO.ui.InputWidget.static.reusePreInfuseDOM = function ( node, config ) {
config = OO.ui.InputWidget.parent.static.reusePreInfuseDOM( node,
config );
- // Reusing $input lets browsers preserve inputted values across page
reloads (T114134)
+ // Reusing `$input` lets browsers preserve inputted values across page
reloads, see T114134.
config.$input = $( node ).find( '.oo-ui-inputWidget-input' );
return config;
};
diff --git a/src/widgets/TextInputWidget.js b/src/widgets/TextInputWidget.js
index dcaad65..68d698f 100644
--- a/src/widgets/TextInputWidget.js
+++ b/src/widgets/TextInputWidget.js
@@ -51,7 +51,7 @@
}, config );
if ( config.multiline ) {
- OO.ui.warnDeprecation( 'TextInputWidget: config.multiline is
deprecated. Use the MultilineTextInputWidget instead. See T130434 for details.'
);
+ OO.ui.warnDeprecation( 'TextInputWidget: config.multiline is
deprecated. Use the MultilineTextInputWidget instead. See T130434.' );
return new OO.ui.MultilineTextInputWidget( config );
}
--
To view, visit https://gerrit.wikimedia.org/r/370347
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb3b611afa228cd62b0185098e51d789f2e2912b
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
