Kaartic has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370467 )
Change subject: Handle other domain links correctly ...................................................................... Handle other domain links correctly Links originating from file pages might be links to other domains such as commons.wikimedia.org, upload.wikimedia.org etc. They were incorrectly prefixed with the Wikisite prefix (https://en.wikipedia.org) which resulted in incorrect links being sent to the Url handler. This regression was introduced as a consequence of, db160f6 Consolidate/solidify LinkHandler Check if they are other domain links and handle them correctly. While at it, reformat a piece of code to be more readable. Change-Id: I6c2091af9fc4a0d4ba5c6230fbe38f0c928a4fe8 --- M app/src/main/java/org/wikipedia/page/LinkHandler.java 1 file changed, 10 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/67/370467/1 diff --git a/app/src/main/java/org/wikipedia/page/LinkHandler.java b/app/src/main/java/org/wikipedia/page/LinkHandler.java index 66f1fd2..bccf1f6 100644 --- a/app/src/main/java/org/wikipedia/page/LinkHandler.java +++ b/app/src/main/java/org/wikipedia/page/LinkHandler.java @@ -48,11 +48,18 @@ @Override public void onUrlClick(@NonNull String href, @Nullable String titleString) { + // other domain links + if (href.startsWith("//")) { + href = "https:" + href; + } + Uri uri = Uri.parse(href); if (!href.startsWith("http:") && !href.startsWith("https:")) { - uri = uri.buildUpon().scheme(getWikiSite().scheme()) - .authority(getWikiSite().authority()) - .path(href).build(); + uri = uri.buildUpon() + .scheme(getWikiSite().scheme()) + .authority(getWikiSite().authority()) + .path(href) + .build(); } Log.d("Wikipedia", "Link clicked was " + uri.toString()); -- To view, visit https://gerrit.wikimedia.org/r/370467 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6c2091af9fc4a0d4ba5c6230fbe38f0c928a4fe8 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Kaartic <kaarticsivaraam91...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
