jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/370757 )
Change subject: Improve some parameter docs
......................................................................
Improve some parameter docs
Change-Id: Ie2ea4ee2bb415e17f903a354170e55b49085414a
---
M CampaignsAuthenticationRequest.php
M composer.json
M phpcs.xml
3 files changed, 4 insertions(+), 6 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/CampaignsAuthenticationRequest.php
b/CampaignsAuthenticationRequest.php
index 918e1a3..29e8d92 100644
--- a/CampaignsAuthenticationRequest.php
+++ b/CampaignsAuthenticationRequest.php
@@ -8,7 +8,7 @@
class CampaignsAuthenticationRequest extends AuthenticationRequest {
public $required = self::OPTIONAL;
- /** @var boolean Whether to use the campaign field from the request */
+ /** @var bool Whether to use the campaign field from the request */
private $useCampaignField;
/** @var string Campaign to log */
@@ -22,7 +22,7 @@
/**
* @param WebRequest $request Request to load data from
- * @param boolean $useCampaignField Whether to actually use the
'campaign' field
+ * @param bool $useCampaignField Whether to actually use the 'campaign'
field
*/
public function __construct( WebRequest $request, $useCampaignField ) {
$this->useCampaignField = $useCampaignField;
diff --git a/composer.json b/composer.json
index bf202bf..fd295f4 100644
--- a/composer.json
+++ b/composer.json
@@ -7,7 +7,7 @@
"scripts": {
"fix": "phpcbf",
"test": [
- "parallel-lint . --exclude vendor",
+ "parallel-lint . --exclude vendor --exclude
node_modules",
"phpcs -p -s"
]
}
diff --git a/phpcs.xml b/phpcs.xml
index bf1d981..b15894e 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -7,7 +7,5 @@
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc" />
- <arg name="encoding" value="utf8" />
- <exclude-pattern>vendor</exclude-pattern>
- <exclude-pattern>node_modules</exclude-pattern>
+ <arg name="encoding" value="UTF-8" />
</ruleset>
--
To view, visit https://gerrit.wikimedia.org/r/370757
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2ea4ee2bb415e17f903a354170e55b49085414a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Campaigns
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: AndyRussG <andrew.green...@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
