jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/371315 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
......................................................................
build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic
* MediaWiki.Commenting.FunctionComment.MissingParamComment
* MediaWiki.Commenting.FunctionComment.MissingParamTag
* MediaWiki.Commenting.FunctionComment.MissingReturn
The following sniffs now pass and were enabled:
* MediaWiki.Commenting.FunctionComment
Change-Id: I0b77d19e7cbb943083ead5b9b13f1fd3fef2cc2d
---
M GraphViz_body.php
M composer.json
M phpcs.xml
3 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/GraphViz_body.php b/GraphViz_body.php
index 7734e3b..cc0e786 100644
--- a/GraphViz_body.php
+++ b/GraphViz_body.php
@@ -251,7 +251,7 @@
public static function titleHasGraphFiles( $title, $path ) {
$globPattern = self::getGraphFileBaseNameFromTitle( $title );
$globPattern = $path . $globPattern . "*.*";
- if ( empty ( glob( $globPattern ) ) ) {
+ if ( empty( glob( $globPattern ) ) ) {
$result = false;
} else {
$result = true;
diff --git a/composer.json b/composer.json
index a6f35be..3ece7b0 100644
--- a/composer.json
+++ b/composer.json
@@ -30,7 +30,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "mediawiki/mediawiki-codesniffer": "0.10.1",
+ "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/phpcs.xml b/phpcs.xml
index b307ee9..e284282 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,10 +1,13 @@
<?xml version="1.0"?>
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
- <exclude name="MediaWiki.Commenting.FunctionComment" />
<exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
<exclude name="Generic.Files.LineLength.TooLong" />
<exclude
name="Generic.NamingConventions.UpperCaseConstantName.ConstantNotUpperCase" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingReturn" />
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc"/>
--
To view, visit https://gerrit.wikimedia.org/r/371315
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b77d19e7cbb943083ead5b9b13f1fd3fef2cc2d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GraphViz
Gerrit-Branch: master
Gerrit-Owner: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
