Jhernandez has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/371941 )
Change subject: Chore: move package headers to keys
......................................................................
Chore: move package headers to keys
- Move package headers to keys to make unique constraints work for
instead of against formatting.
- Set commands to commented out descriptions to clarify divisional
differences.
- Move "tools" to "secondary" to avoid confusion where a primary script
is also a tool. Since these scripts appear to be public and useful to
the user, although infrequently used, move them above hooks and
internal tooling which are protected and private-ish, respectively.
- Rename "main scripts" to "primary" for consistency with "secondary".
- Rename "helpers" to "internal" to indicate that the client is not
expected to find these commands useful or invoke them. They exist only
for internal usage.
Change-Id: I5da2a8e1f03a68a3679717990b5584379195751e
---
M package.json
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
Jhernandez: Verified; Looks good to me, approved
diff --git a/package.json b/package.json
index 6a38aac..b290864 100644
--- a/package.json
+++ b/package.json
@@ -3,23 +3,23 @@
"version": "0.0.0",
"description": "An API driven skin for MediaWiki",
"scripts": {
- "//": "MAIN SCRIPTS",
+ "--- PRIMARY ---": "# Frequent user scripts.",
"start": "run-p -sn 'client:build -- -w' 'server:build -- -w'
server:watch",
"build": "NODE_ENV=production npm-run-all --silent clean --parallel
server:build 'client:build -- -p'",
"format": "npm run -s lint -- --fix",
"lint": "eslint --cache --max-warnings 0 --ext ts,tsx,js,json .",
"test": "run-p -sn lint build mocha",
"test:watch": "nodemon -e js,json,ts,tsx -q -x 'npm test'",
- "//-": "HOOKS",
+ "--- SECONDARY ---": "# Useful but rarely used scripts.",
+ "mocha": "mocha '{src,test}/**/*.test.{ts,js}'",
+ "clean": "rm -rf dist/",
+ "--- HOOKS ---": "# Triggered scripts.",
"precommit": "npm test -s",
- "//--": "HELPERS",
+ "--- INTERNAL ---": "# Private scripts.",
"server:watch": "nodemon -e js,json,ts,tsx -q -x 'npm run server:run'",
"server:build": "tsc -p src/server/tsconfig.json",
"server:run": "node dist/server/index.js",
- "client:build": "webpack --display minimal",
- "//---": "TOOLS",
- "mocha": "mocha '{src,test}/**/*.test.{ts,js}'",
- "clean": "rm -rf dist/"
+ "client:build": "webpack --display minimal"
},
"repository": {
"type": "git",
--
To view, visit https://gerrit.wikimedia.org/r/371941
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5da2a8e1f03a68a3679717990b5584379195751e
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: Jhernandez <jhernan...@wikimedia.org>
Gerrit-Reviewer: Sniedzielski <sniedziel...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
