jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/370513 )
Change subject: Fix broken tests ...................................................................... Fix broken tests 1) Reflect template change: Link has changed from Help:IPA for English to Help:IPA/English https://en.m.wikipedia.org/wiki/Special:MobileDiff/794002013 2) The action API doesn't return a Wikidata description for Main Pages. See T172829 Bug: T172829 Change-Id: I91a840fa0d6e6fe5a57a235285dc4bbdf5297929 --- M spec.yaml M test/diff/results/page_formatted-enwiki-User%3ABSitzmann_(WMF)_MCS_Test_Frankenstein.json M test/diff/results/page_formatted-enwiki-User%3ABSitzmann_(WMF)_MCS_Test_Frankenstein/section3-text.html M test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_(WMF)_MCS_Test_Frankenstein.json M test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_(WMF)_MCS_Test_Frankenstein/section3-text.html M test/features/mobile-sections/pagecontent.js 6 files changed, 4 insertions(+), 6 deletions(-) Approvals: BearND: Looks good to me, approved jenkins-bot: Verified Jdlrobson: Looks good to me, but someone else must approve diff --git a/spec.yaml b/spec.yaml index 6bb3913..164553d 100644 --- a/spec.yaml +++ b/spec.yaml @@ -630,7 +630,6 @@ displaytitle: /.+/ normalizedtitle: /.+/ wikibase_item: Q5296 - description: /[Mm]ain [Pp]age/ protection: /.+/ editable: /.+/ mainpage: true diff --git "a/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json" "b/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json" index d80bea7..b9d2c8d 100644 --- "a/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json" +++ "b/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json" @@ -36,7 +36,7 @@ }, { "id": 3, - "text": "\n<p><b>Konjac</b> (<span><span class=\"ipa_button\"></span><span class=\"nowrap mcs-ipa\"><small>English: </small><span class=\"IPA nopopups noexcerpt\"><a href=\"./Help:IPA_for_English\" title=\"Help:IPA for English\">/<span style=\"border-bottom:1px dotted\"><span>ˈ</span><span>k</span><span>oʊ</span><span>n</span><span>j</span><span>æ</span><span>k</span></span>/</a></span></span></span> <a href=\"./Help:Pronunciation_respelling_key\" title=\"Help:Pronunciation respelling key\"><small title=\"English pronunciation respelling\"><i><b>KOHN</b>-yak</i></small></a>)</p>\n\n", + "text": "\n<p><b>Konjac</b> (<span><span class=\"ipa_button\"></span><span class=\"nowrap mcs-ipa\"><small>English: </small><span class=\"IPA nopopups noexcerpt\"><a href=\"./Help:IPA/English\" title=\"Help:IPA/English\">/<span style=\"border-bottom:1px dotted\"><span>ˈ</span><span>k</span><span>oʊ</span><span>n</span><span>j</span><span>æ</span><span>k</span></span>/</a></span></span></span> <a href=\"./Help:Pronunciation_respelling_key\" title=\"Help:Pronunciation respelling key\"><small title=\"English pronunciation respelling\"><i><b>KOHN</b>-yak</i></small></a>)</p>\n\n", "toclevel": 1, "line": "Pronunciation aids", "anchor": "Pronunciation_aids" diff --git "a/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section3-text.html" "b/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section3-text.html" index a6db74f..bb4dfad 100644 --- "a/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section3-text.html" +++ "b/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section3-text.html" @@ -1,5 +1,5 @@ <p> - <b>Konjac</b> (<span><span class="ipa_button"></span><span class="nowrap mcs-ipa"><small>English: </small><span class="IPA nopopups noexcerpt"><a href="./Help:IPA_for_English" title="Help:IPA for English">/<span style="border-bottom:1px dotted"><span>ˈ</span><span>k</span><span>oʊ</span><span>n</span><span>j</span><span>æ</span><span>k</span></span>/</a> + <b>Konjac</b> (<span><span class="ipa_button"></span><span class="nowrap mcs-ipa"><small>English: </small><span class="IPA nopopups noexcerpt"><a href="./Help:IPA_for_English" title="Help:IPA/English">/<span style="border-bottom:1px dotted"><span>ˈ</span><span>k</span><span>oʊ</span><span>n</span><span>j</span><span>æ</span><span>k</span></span>/</a> </span> </span> </span> <a href="./Help:Pronunciation_respelling_key" title="Help:Pronunciation respelling key"><small title="English pronunciation respelling"><i><b>KOHN</b>-yak</i></small></a>)</p> diff --git "a/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json" "b/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json" index 7676792..244222d 100644 --- "a/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json" +++ "b/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json" @@ -190,7 +190,7 @@ }, { "id": 3, - "text": "\n<p><b>Konjac</b> (<span><span class=\"ipa_button\"></span><span class=\"nowrap mcs-ipa\" style=\"display: none;\"><small>English: </small><span class=\"IPA nopopups noexcerpt\"><a href=\"/wiki/Help:IPA_for_English\" title=\"Help:IPA for English\">/<span style=\"border-bottom:1px dotted\"><span>ˈ</span><span>k</span><span>oʊ</span><span>n</span><span>j</span><span>æ</span><span>k</span></span>/</a></span></span></span> <a href=\"/wiki/Help:Pronunciation_respelling_key\" title=\"Help:Pronunciation respelling key\"><small title=\"English pronunciation respelling\"><i><b>KOHN</b>-yak</i></small></a>)</p>\n\n", + "text": "\n<p><b>Konjac</b> (<span><span class=\"ipa_button\"></span><span class=\"nowrap mcs-ipa\" style=\"display: none;\"><small>English: </small><span class=\"IPA nopopups noexcerpt\"><a href=\"/wiki/Help:IPA/English\" title=\"Help:IPA/English\">/<span style=\"border-bottom:1px dotted\"><span>ˈ</span><span>k</span><span>oʊ</span><span>n</span><span>j</span><span>æ</span><span>k</span></span>/</a></span></span></span> <a href=\"/wiki/Help:Pronunciation_respelling_key\" title=\"Help:Pronunciation respelling key\"><small title=\"English pronunciation respelling\"><i><b>KOHN</b>-yak</i></small></a>)</p>\n\n", "toclevel": 1, "line": "Pronunciation aids", "anchor": "Pronunciation_aids" diff --git "a/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section3-text.html" "b/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section3-text.html" index 684cf49..8887298 100644 --- "a/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section3-text.html" +++ "b/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section3-text.html" @@ -1,5 +1,5 @@ <p> - <b>Konjac</b> (<span><span class="ipa_button"></span><span class="nowrap mcs-ipa" style="display: none;"><small>English: </small><span class="IPA nopopups noexcerpt"><a href="/wiki/Help:IPA_for_English" title="Help:IPA for English">/<span style="border-bottom:1px dotted"><span>ˈ</span><span>k</span><span>oʊ</span><span>n</span><span>j</span><span>æ</span><span>k</span></span>/</a> + <b>Konjac</b> (<span><span class="ipa_button"></span><span class="nowrap mcs-ipa" style="display: none;"><small>English: </small><span class="IPA nopopups noexcerpt"><a href="/wiki/Help:IPA_for_English" title="Help:IPA/English">/<span style="border-bottom:1px dotted"><span>ˈ</span><span>k</span><span>oʊ</span><span>n</span><span>j</span><span>æ</span><span>k</span></span>/</a> </span> </span> </span> <a href="/wiki/Help:Pronunciation_respelling_key" title="Help:Pronunciation respelling key"><small title="English pronunciation respelling"><i><b>KOHN</b>-yak</i></small></a>)</p> diff --git a/test/features/mobile-sections/pagecontent.js b/test/features/mobile-sections/pagecontent.js index 01f9c07..dc072f4 100644 --- a/test/features/mobile-sections/pagecontent.js +++ b/test/features/mobile-sections/pagecontent.js @@ -67,7 +67,6 @@ assert.equal(lead.displaytitle, 'Main Page'); assert.equal(lead.normalizedtitle, 'Main Page'); assert.equal(lead.wikibase_item, 'Q5296'); - assert.ok(/main page/i.test(lead.description)); assert.deepEqual(lead.protection, { "edit": [ "sysop" -- To view, visit https://gerrit.wikimedia.org/r/370513 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91a840fa0d6e6fe5a57a235285dc4bbdf5297929 Gerrit-PatchSet: 8 Gerrit-Project: mediawiki/services/mobileapps Gerrit-Branch: master Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org> Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org> Gerrit-Reviewer: Fjalapeno <cfl...@wikimedia.org> Gerrit-Reviewer: GWicke <gwi...@wikimedia.org> Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: Jhernandez <jhernan...@wikimedia.org> Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org> Gerrit-Reviewer: Mhurd <mh...@wikimedia.org> Gerrit-Reviewer: Mobrovac <mobro...@wikimedia.org> Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org> Gerrit-Reviewer: Ppchelko <ppche...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
