jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/336052 )
Change subject: Prevent overlap of sidebar column with everything else ...................................................................... Prevent overlap of sidebar column with everything else The .articleplaceholder-sidebar is floated to the left. This is what we want. However, if the .articleplaceholder-identifierlist does not contain many items then statement-groups can appear under it. This creates a slightly off-topic look to the page. This commit should prevent this by setting the statement-group list to `width: auto` and `overflow: hidden`, as per https://stackoverflow.com/a/5195902/5013691. Note that this must happen only when the viewport is at least 912px wide, or the statement-groups will be partially cut off due to their fixed size. Bug: T149193 Change-Id: I295fccdf476e739eadb4ff29797691ba732fda6b --- M modules/ext.articleplaceholder.defaultDisplay/ext.articleplaceholder.defaultDisplay.css 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: Ladsgroup: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/ext.articleplaceholder.defaultDisplay/ext.articleplaceholder.defaultDisplay.css b/modules/ext.articleplaceholder.defaultDisplay/ext.articleplaceholder.defaultDisplay.css index 211188d..4e5d96c 100644 --- a/modules/ext.articleplaceholder.defaultDisplay/ext.articleplaceholder.defaultDisplay.css +++ b/modules/ext.articleplaceholder.defaultDisplay/ext.articleplaceholder.defaultDisplay.css @@ -54,6 +54,23 @@ margin-top: 1.5em; } +/* + * At screen widths between 982px and 880px, statementgroups's right edges + * are 911px from the left side of the screen (including the 1px border). + * However, the sidebar's float is only set to `none` at 880px, resulting in + * the right side of the statementgroups being cut off if we apply + * `overflow: hidden` to the statementgrouplist. However, we need + * `overflow: hidden` in order to prevent statementgroups from appearing under + * the sidebar. To work around this, we only apply `overflow: hidden` at screen + * sizes at least 912px wide (with 1 extra pixel for breathing room). + */ +@media screen and ( min-width: 912px ) { + .articleplaceholder-statementgrouplist { + width: auto; + overflow: hidden; + } +} + .articleplaceholder-qualifier { margin-left: 1em; } -- To view, visit https://gerrit.wikimedia.org/r/336052 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I295fccdf476e739eadb4ff29797691ba732fda6b Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/ArticlePlaceholder Gerrit-Branch: master Gerrit-Owner: Jo12bar <johan...@telus.net> Gerrit-Reviewer: Hoo man <h...@online.de> Gerrit-Reviewer: Jo12bar <johan...@telus.net> Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com> Gerrit-Reviewer: Lucie Kaffee <lucie.kaf...@gmail.com> Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
