Jhernandez has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372182 )

Change subject: Fix: update compiler configuration
......................................................................


Fix: update compiler configuration

- Use Node module resolution strategy.

  https://www.typescriptlang.org/docs/handbook/module-resolution.html

- Don't compile test files to dist/. Note: the globbing support appears
  to be minimal.

  https://www.typescriptlang.org/docs/handbook/tsconfig-json.html#details

- Remove Mocha support for JSX files. These are not passed to Mocha so
  there's no compiler needed.

- Enable "pretty" compiler output.

Change-Id: I2f3add9e6934989fb5fe7bc4afcbd0685c5b3273
---
M test/mocha.opts
M tsconfig.json
2 files changed, 12 insertions(+), 2 deletions(-)

Approvals:
  Jhernandez: Verified; Looks good to me, approved



diff --git a/test/mocha.opts b/test/mocha.opts
index 14d88f9..775f673 100644
--- a/test/mocha.opts
+++ b/test/mocha.opts
@@ -1 +1 @@
---compilers ts:ts-node/register,tsx:ts-node/register
+--compilers ts:ts-node/register
diff --git a/tsconfig.json b/tsconfig.json
index 311848a..cdff908 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -1,7 +1,14 @@
 {
+  "exclude": [
+    "src/**/*.test.ts",
+    "src/**/*.test.js",
+    "test/**/*.test.ts",
+    "test/**/*.test.js"
+  ],
   "compilerOptions": {
     "jsx": "react",
     "jsxFactory": "h",
+    "moduleResolution": "node",
     "sourceMap": true,
 
     "strict": true,
@@ -12,6 +19,9 @@
     "noFallthroughCasesInSwitch": true,
 
     "newLine": "lf",
-    "forceConsistentCasingInFileNames": true
+    "forceConsistentCasingInFileNames": true,
+
+    // Not available for ts-node: 
https://github.com/TypeStrong/ts-node/issues/374
+    "pretty": true
   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/372182
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2f3add9e6934989fb5fe7bc4afcbd0685c5b3273
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
Gerrit-Reviewer: Jhernandez <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to