MaxSem has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372555 )
Change subject: Reinforce LoginNotify settings
......................................................................
Reinforce LoginNotify settings
Instead of reproducing the conditions of Echo usage, check explicitly
if it's enabled, this way is more future proof.
Change-Id: Ib7767ddfffe95f86b9d3b0bcc02c49b3f67cf6d4
---
M wmf-config/CommonSettings.php
M wmf-config/InitialiseSettings.php
2 files changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config
refs/changes/55/372555/1
diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index bc395ae..a91902d 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -1975,7 +1975,7 @@
wfLoadExtension( 'TemplateStyles' );
}
-if ( $wmgUseLoginNotify ) {
+if ( $wmgUseLoginNotify && $wmgUseEcho ) {
wfLoadExtension( 'LoginNotify' );
$wgNotifyTypeAvailabilityByCategory['login-success']['web'] = false;
diff --git a/wmf-config/InitialiseSettings.php
b/wmf-config/InitialiseSettings.php
index 1f05ad4..65591bc 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -19351,7 +19351,6 @@
'wmgUseLoginNotify' => [
'default' => true,
- 'nonecho' => false,
],
'wmgUseCodeMirror' => [
--
To view, visit https://gerrit.wikimedia.org/r/372555
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7767ddfffe95f86b9d3b0bcc02c49b3f67cf6d4
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: MaxSem <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
