jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372776 )

Change subject: [IMPR] Some improvements
......................................................................


[IMPR] Some improvements

- change table columns
- use last activity instead of last edit

Change-Id: Ia5cafb3fee3c6a09831dc1538b2f1c0dee695a2e
---
M imagereview.py
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  jenkins-bot: Verified
  Xqt: Looks good to me, approved



diff --git a/imagereview.py b/imagereview.py
index 0bfebad..523ca1b 100644
--- a/imagereview.py
+++ b/imagereview.py
@@ -682,7 +682,7 @@
         text = """
 {| class="wikitable sortable"
 |-
-! Datei || Uploader || Zeitstempel || Benachrichtigt || Letzte Aktivität
+! Datei || Zeitstempel || Uploader || Benachrichtigt || Letzte Aktivität
 |-
 """
         if self.getOption('check'):
@@ -724,9 +724,11 @@
 ##                               % (a[2].title(), key)
                 username, timestamp = fileinfo
                 user = pywikibot.User(self.site, username)
-                lastedit = next(user.contributions(total=1))[2]
-                text += ('| {filename} || [[Benutzer:{username}]] |'
-                         '| {timestamp} || {notified} || {lastedit}\n|- \n'
+                lastevent = next(iter(self.site.logevents(
+                    user=username, total=1))).timestamp().isoformat()
+                text += ('| {filename} || {timestamp} |'
+                         '| [[Benutzer:{username}]] || {notified} |'
+                         '| {lastevent}\n|- \n'
                          .format(**locals()))
         text += u'|}'
         if save:

-- 
To view, visit https://gerrit.wikimedia.org/r/372776
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5cafb3fee3c6a09831dc1538b2f1c0dee695a2e
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/bots/xqbot
Gerrit-Branch: master
Gerrit-Owner: Xqt <i...@gno.de>
Gerrit-Reviewer: Xqt <i...@gno.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to