Niedzielski has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/373044 )
Change subject: Chore: Disable forceConsistentCasingInFileNames because of issues in OSX ...................................................................... Chore: Disable forceConsistentCasingInFileNames because of issues in OSX See https://github.com/Microsoft/TypeScript/issues/17617 Since we added typeRoots, typescript fails in OSX with messages like: error TS1149: File name '/users/jhernandez/dev/marvin/node_modules/@types/assets-webpack-plugin/index.d.ts' differs from already included file name '/Users/jhernandez/dev/marvin/node_modules/@types/assets-webpack-plugin/index.d.ts' only in casing. This patch fixes the OSX problems by disabling forceConsistentCasingInFileNames until the issue is resolved. Change-Id: Icb1af707d8f368069518a25227540987f6db06b9 --- M tsconfig.json 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Niedzielski: Verified; Looks good to me, approved diff --git a/tsconfig.json b/tsconfig.json index edcd41d..baefc3c 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -28,7 +28,9 @@ ], "newLine": "lf", - "forceConsistentCasingInFileNames": true, + // This option creates problems with the typeRoots in OS X. See: + // https://github.com/Microsoft/TypeScript/issues/17617 + "forceConsistentCasingInFileNames": false, // Not available for ts-node: https://github.com/TypeStrong/ts-node/issues/374 "pretty": true -- To view, visit https://gerrit.wikimedia.org/r/373044 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb1af707d8f368069518a25227540987f6db06b9 Gerrit-PatchSet: 1 Gerrit-Project: marvin Gerrit-Branch: master Gerrit-Owner: Jhernandez <[email protected]> Gerrit-Reviewer: Jhernandez <[email protected]> Gerrit-Reviewer: Niedzielski <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
