VolkerE has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373152 )
Change subject: Update OOjs UI to v0.22.5 ...................................................................... Update OOjs UI to v0.22.5 Release notes: https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.22.5 Change-Id: Icf08f8c12d91b74425df319e69df22330c7088a9 --- M composer.json M composer.lock M composer/installed.json M oojs/oojs-ui/History.md M oojs/oojs-ui/i18n/en.json M oojs/oojs-ui/i18n/ja.json A oojs/oojs-ui/i18n/kab.json M oojs/oojs-ui/i18n/li.json M oojs/oojs-ui/i18n/nn.json M oojs/oojs-ui/i18n/qqq.json A oojs/oojs-ui/i18n/skr-arab.json M oojs/oojs-ui/i18n/yue.json M oojs/oojs-ui/package.json M oojs/oojs-ui/php/Element.php M oojs/oojs-ui/php/Tag.php M oojs/oojs-ui/php/Widget.php M oojs/oojs-ui/php/layouts/PanelLayout.php M oojs/oojs-ui/php/mixins/ButtonElement.php M oojs/oojs-ui/php/mixins/FlaggedElement.php M oojs/oojs-ui/php/mixins/GroupElement.php M oojs/oojs-ui/php/widgets/ButtonInputWidget.php M oojs/oojs-ui/php/widgets/ButtonWidget.php M oojs/oojs-ui/php/widgets/CheckboxInputWidget.php M oojs/oojs-ui/php/widgets/ProgressBarWidget.php M oojs/oojs-ui/php/widgets/RadioInputWidget.php M oojs/oojs-ui/php/widgets/TextInputWidget.php 26 files changed, 145 insertions(+), 78 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vendor refs/changes/52/373152/1 diff --git a/composer.json b/composer.json index 2dcfd8d..53ee081 100644 --- a/composer.json +++ b/composer.json @@ -45,7 +45,7 @@ "monolog/monolog": "1.22.1", "mustangostang/spyc": "0.6.2", "nmred/kafka-php": "0.1.5", - "oojs/oojs-ui": "0.22.4", + "oojs/oojs-ui": "0.22.5", "oyejorge/less.php": "1.7.0.14", "pear/console_getopt": "1.4.1", "pear/mail": "1.4.1", diff --git a/composer.lock b/composer.lock index 355956c..0bb1173 100644 --- a/composer.lock +++ b/composer.lock @@ -4,7 +4,7 @@ "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file";, "This file is @generated automatically" ], - "content-hash": "301c4a097e044e617ab5b804f5b99a22", + "content-hash": "8e3ab52a0544abb4d7450ab1ae3c1374", "packages": [ { "name": "composer/semver", @@ -516,16 +516,16 @@ }, { "name": "oojs/oojs-ui", - "version": "v0.22.4", + "version": "v0.22.5", "source": { "type": "git", "url": "https://github.com/wikimedia/oojs-ui.git";, - "reference": "bb1b15c47835468f133a56aa56a721f8793c61f7" + "reference": "5ebb89bc94cf1d15772bfd624cc5c96ebbeafd7d" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/wikimedia/oojs-ui/zipball/bb1b15c47835468f133a56aa56a721f8793c61f7";, - "reference": "bb1b15c47835468f133a56aa56a721f8793c61f7", + "url": "https://api.github.com/repos/wikimedia/oojs-ui/zipball/5ebb89bc94cf1d15772bfd624cc5c96ebbeafd7d";, + "reference": "5ebb89bc94cf1d15772bfd624cc5c96ebbeafd7d", "shasum": "" }, "require": { @@ -534,7 +534,7 @@ }, "require-dev": { "jakub-onderka/php-parallel-lint": "0.9.2", - "mediawiki/mediawiki-codesniffer": "0.10.0", + "mediawiki/mediawiki-codesniffer": "0.11.0", "phpunit/phpunit": "4.8.21" }, "type": "library", @@ -591,7 +591,7 @@ ], "description": "Provides library of common widgets, layouts, and windows.", "homepage": "https://www.mediawiki.org/wiki/OOjs_UI";, - "time": "2017-08-01T19:55:30+00:00" + "time": "2017-08-22T21:02:41+00:00" }, { "name": "oyejorge/less.php", diff --git a/composer/installed.json b/composer/installed.json index f37cf29..bcb7a6c 100644 --- a/composer/installed.json +++ b/composer/installed.json @@ -2326,17 +2326,17 @@ }, { "name": "oojs/oojs-ui", - "version": "v0.22.4", - "version_normalized": "0.22.4.0", + "version": "v0.22.5", + "version_normalized": "0.22.5.0", "source": { "type": "git", "url": "https://github.com/wikimedia/oojs-ui.git";, - "reference": "bb1b15c47835468f133a56aa56a721f8793c61f7" + "reference": "5ebb89bc94cf1d15772bfd624cc5c96ebbeafd7d" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/wikimedia/oojs-ui/zipball/bb1b15c47835468f133a56aa56a721f8793c61f7";, - "reference": "bb1b15c47835468f133a56aa56a721f8793c61f7", + "url": "https://api.github.com/repos/wikimedia/oojs-ui/zipball/5ebb89bc94cf1d15772bfd624cc5c96ebbeafd7d";, + "reference": "5ebb89bc94cf1d15772bfd624cc5c96ebbeafd7d", "shasum": "" }, "require": { @@ -2345,10 +2345,10 @@ }, "require-dev": { "jakub-onderka/php-parallel-lint": "0.9.2", - "mediawiki/mediawiki-codesniffer": "0.10.0", + "mediawiki/mediawiki-codesniffer": "0.11.0", "phpunit/phpunit": "4.8.21" }, - "time": "2017-08-01T19:55:30+00:00", + "time": "2017-08-22T21:02:41+00:00", "type": "library", "installation-source": "dist", "autoload": { diff --git a/oojs/oojs-ui/History.md b/oojs/oojs-ui/History.md index f427087..3c6eaec 100644 --- a/oojs/oojs-ui/History.md +++ b/oojs/oojs-ui/History.md @@ -1,4 +1,24 @@ # OOjs UI Release History +## v0.22.5 / 2017-08-22 +### Features +* Add `title` attribute to the 'remove' button in TagItemWidget (Moriel Schottlender) + +### Styles +* WikimediaUI theme: Fix regression on disabled border (Volker E.) + +### Code +* Align vars to WikimediaUI Base and remove them as OOjs UI vars (Volker E.) +* DraggableElement: Make toggling draggability consistent (Bartosz Dziewoński) +* Follow-up 022f532: Don't crash if TitledElement initializes before AccessKeyedElement (Roan Kattouw) +* WikimediaUI theme: Make checkbox/radio code leaner (Volker E.) +* WikimediaUI theme: Remove unnecessary selector in CheckboxInputWidget (Volker E.) +* doc: Align code comment references to Phabricator tasks (Volker E.) +* build: Upgrade devDependencies to latest and make pass (James D. Forrester) +* build: Update mediawiki-codesniffer to v0.10.1 and fix issues (WMDE-Fisch) +* build: Update mediawiki-codesniffer to v0.11.0 and fix issues (WMDE-Fisch) +* tests: Prepare for qunit 2.x (James D. Forrester) + + ## v0.22.4 / 2017-08-01 ### Features * CheckboxMultiselectInputWidget: setValue when CheckboxMultiselect changes (Prateek Saxena) diff --git a/oojs/oojs-ui/i18n/en.json b/oojs/oojs-ui/i18n/en.json index be00832..fd31150 100644 --- a/oojs/oojs-ui/i18n/en.json +++ b/oojs/oojs-ui/i18n/en.json @@ -22,6 +22,7 @@ "ooui-toolbar-more": "More", "ooui-toolgroup-expand": "More", "ooui-toolgroup-collapse": "Fewer", + "ooui-item-remove": "Remove", "ooui-dialog-message-accept": "OK", "ooui-dialog-message-reject": "Cancel", "ooui-dialog-process-error": "Something went wrong", diff --git a/oojs/oojs-ui/i18n/ja.json b/oojs/oojs-ui/i18n/ja.json index d0df027..308cb80 100644 --- a/oojs/oojs-ui/i18n/ja.json +++ b/oojs/oojs-ui/i18n/ja.json @@ -7,14 +7,15 @@ "Shirayuki", "Takot", "Los688", - "Sujiniku" + "Sujiniku", + "Translatealcd" ] }, "ooui-outline-control-move-down": "項目を下に移動させる", "ooui-outline-control-move-up": "項目を上に移動させる", "ooui-outline-control-remove": "項目を除去", "ooui-toolbar-more": "その他", - "ooui-toolgroup-expand": "続き", + "ooui-toolgroup-expand": "その他", "ooui-toolgroup-collapse": "折り畳む", "ooui-dialog-message-accept": "OK", "ooui-dialog-message-reject": "キャンセル", diff --git a/oojs/oojs-ui/i18n/kab.json b/oojs/oojs-ui/i18n/kab.json new file mode 100644 index 0000000..caee378 --- /dev/null +++ b/oojs/oojs-ui/i18n/kab.json @@ -0,0 +1,21 @@ +{ + "@metadata": { + "authors": [ + "Belkacem77" + ] + }, + "ooui-outline-control-move-down": "Awi aferdi d akesser", + "ooui-outline-control-move-up": "Awi aferdis d asawen", + "ooui-outline-control-remove": "Kkes aferdis", + "ooui-toolbar-more": "Ugar", + "ooui-toolgroup-expand": "Ugar", + "ooui-toolgroup-collapse": "Drus", + "ooui-dialog-message-accept": "IH", + "ooui-dialog-message-reject": "Sefsex", + "ooui-dialog-process-retry": "Ɛreḍ tikelt-nniden", + "ooui-dialog-process-continue": "Kemmel", + "ooui-selectfile-button-select": "Fren afaylu", + "ooui-selectfile-not-supported": "Afran n ufaylu ur yettusefrak ara", + "ooui-selectfile-placeholder": "Ulac afaylu yettwafernen", + "ooui-selectfile-dragdrop-placeholder": "Sers afaylu dagi" +} diff --git a/oojs/oojs-ui/i18n/li.json b/oojs/oojs-ui/i18n/li.json index f05a957..0012c9c 100644 --- a/oojs/oojs-ui/i18n/li.json +++ b/oojs/oojs-ui/i18n/li.json @@ -1,7 +1,8 @@ { "@metadata": { "authors": [ - "Pahles" + "Pahles", + "Ooswesthoesbes" ] }, "ooui-outline-control-move-down": "Item nao ónger verplaatse", @@ -16,6 +17,8 @@ "ooui-dialog-process-dismiss": "Sjlete", "ooui-dialog-process-retry": "Perbeer obbenuujts", "ooui-dialog-process-continue": "Doorgaon", + "ooui-selectfile-button-select": "Kees e bestandj", "ooui-selectfile-not-supported": "Selektie van 'n besjtandj waert neet óngersteund", - "ooui-selectfile-placeholder": "Dao is gein besjtandj geselekteerd" + "ooui-selectfile-placeholder": "Dao is gein besjtandj geselekteerd", + "ooui-selectfile-dragdrop-placeholder": "Sleip e bestandj hieroppes" } diff --git a/oojs/oojs-ui/i18n/nn.json b/oojs/oojs-ui/i18n/nn.json index e3f3e11..a32e7a4 100644 --- a/oojs/oojs-ui/i18n/nn.json +++ b/oojs/oojs-ui/i18n/nn.json @@ -15,5 +15,6 @@ "ooui-dialog-process-dismiss": "Lat att", "ooui-dialog-process-continue": "Hald fram", "ooui-selectfile-button-select": "Vel ei fil", - "ooui-selectfile-placeholder": "Inga fil er vald" + "ooui-selectfile-placeholder": "Inga fil er vald", + "ooui-selectfile-dragdrop-placeholder": "Slepp fil her" } diff --git a/oojs/oojs-ui/i18n/qqq.json b/oojs/oojs-ui/i18n/qqq.json index 1a096ef..270cfe9 100644 --- a/oojs/oojs-ui/i18n/qqq.json +++ b/oojs/oojs-ui/i18n/qqq.json @@ -26,6 +26,7 @@ "ooui-toolbar-more": "Label for the toolbar group that contains a list of all other available tools.\n{{Identical|More}}", "ooui-toolgroup-expand": "Label for the fake tool that expands the full list of tools in a toolbar group.\n\nSee also:\n* {{msg-mw|Ooui-toolgroup-collapse}}\n{{Identical|More}}", "ooui-toolgroup-collapse": "Label for the fake tool that collapses the full list of tools in a toolbar group.\n\nSee also:\n* {{msg-mw|Ooui-toolgroup-expand}}\n{{Identical|Fewer}}", + "ooui-item-remove": "Text for the action of removing an item", "ooui-dialog-message-accept": "Default label for the accept button of a message dialog\n{{Identical|OK}}", "ooui-dialog-message-reject": "Default label for the reject button of a message dialog\n{{Identical|Cancel}}", "ooui-dialog-process-error": "Title for process dialog error description", diff --git a/oojs/oojs-ui/i18n/skr-arab.json b/oojs/oojs-ui/i18n/skr-arab.json new file mode 100644 index 0000000..6be2354 --- /dev/null +++ b/oojs/oojs-ui/i18n/skr-arab.json @@ -0,0 +1,18 @@ +{ + "@metadata": { + "authors": [ + "Saraiki" + ] + }, + "ooui-toolbar-more": "ٻئے", + "ooui-toolgroup-expand": "ٻئے", + "ooui-toolgroup-collapse": "گھٹ", + "ooui-dialog-message-accept": "ٹھیک ہے", + "ooui-dialog-message-reject": "منسوخ", + "ooui-dialog-process-error": "کجھ خراب تھی ڳئے", + "ooui-dialog-process-dismiss": "مکاؤ", + "ooui-dialog-process-retry": "ولدا کوشش کرو", + "ooui-dialog-process-continue": "جاری رکھو", + "ooui-selectfile-button-select": "فائل چݨو", + "ooui-selectfile-placeholder": "کوئی فائل کائنی چُݨی" +} diff --git a/oojs/oojs-ui/i18n/yue.json b/oojs/oojs-ui/i18n/yue.json index 629528d..6a9e902 100644 --- a/oojs/oojs-ui/i18n/yue.json +++ b/oojs/oojs-ui/i18n/yue.json @@ -4,13 +4,14 @@ "Deryck Chan", "William915", "Shinjiman", - "Ktchankt" + "Ktchankt", + "Hello903hello" ] }, "ooui-outline-control-move-down": "向下搬", "ooui-outline-control-move-up": "向上搬", "ooui-outline-control-remove": "拎走", - "ooui-toolbar-more": "仲有", + "ooui-toolbar-more": "更多", "ooui-toolgroup-expand": "更多", "ooui-toolgroup-collapse": "少啲", "ooui-dialog-message-accept": "好", diff --git a/oojs/oojs-ui/package.json b/oojs/oojs-ui/package.json index a6a2365..a456388 100644 --- a/oojs/oojs-ui/package.json +++ b/oojs/oojs-ui/package.json @@ -1,6 +1,6 @@ { "name": "oojs-ui", - "version": "0.22.4", + "version": "0.22.5", "description": "User interface classes built on the OOjs framework.", "keywords": [ "oojs-plugin", @@ -31,16 +31,16 @@ "eslint-config-wikimedia": "0.4.0", "grunt": "1.0.1", "grunt-banana-checker": "0.6.0", - "grunt-contrib-clean": "1.0.0", + "grunt-contrib-clean": "1.1.0", "grunt-contrib-concat": "1.0.1", "grunt-contrib-copy": "1.0.0", - "grunt-contrib-cssmin": "2.0.0", + "grunt-contrib-cssmin": "2.2.1", "grunt-contrib-less": "1.4.1", - "grunt-contrib-uglify": "2.2.0", + "grunt-contrib-uglify": "3.0.1", "grunt-contrib-watch": "1.0.0", "grunt-cssjanus": "0.4.0", - "grunt-eslint": "19.0.0", - "grunt-exec": "1.0.1", + "grunt-eslint": "20.0.0", + "grunt-exec": "3.0.0", "grunt-file-exists": "0.1.4", "grunt-image": "1.5.2", "grunt-jsonlint": "1.1.0", @@ -51,15 +51,15 @@ "grunt-svg2png": "git://github.com/jdforrester/grunt-svg2png.git#v0.2.7-wmf.1", "grunt-tyops": "0.1.0", "javascript-stringify": "1.6.0", - "karma": "1.1.1", - "karma-chrome-launcher": "1.0.1", - "karma-coverage": "1.1.0", - "karma-firefox-launcher": "1.0.0", - "karma-qunit": "1.1.0", + "karma": "1.7.0", + "karma-chrome-launcher": "2.2.0", + "karma-coverage": "1.1.1", + "karma-firefox-launcher": "1.0.1", + "karma-qunit": "1.2.1", "karma-remap-istanbul": "0.6.0", "prismjs": "1.6.0", - "q": "1.4.1", - "qunitjs": "1.22.0", + "q": "1.5.0", + "qunitjs": "2.4.0", "stylelint": "7.8.0", "stylelint-config-wikimedia": "0.4.1" } diff --git a/oojs/oojs-ui/php/Element.php b/oojs/oojs-ui/php/Element.php index bd90d15..04c81e0 100644 --- a/oojs/oojs-ui/php/Element.php +++ b/oojs/oojs-ui/php/Element.php @@ -125,7 +125,7 @@ * Check if element supports one or more methods. * * @param string|string[] $methods Method or list of methods to check - * @return boolean All methods are supported + * @return bool All methods are supported */ public function supports( $methods ) { $support = 0; diff --git a/oojs/oojs-ui/php/Tag.php b/oojs/oojs-ui/php/Tag.php index 9273455..1c308bd 100644 --- a/oojs/oojs-ui/php/Tag.php +++ b/oojs/oojs-ui/php/Tag.php @@ -63,7 +63,7 @@ * Check for CSS class. * * @param string $class CSS class name - * @return boolean + * @return bool */ public function hasClass( $class ) { return in_array( $class, $this->classes ); @@ -95,7 +95,7 @@ * Toggle CSS classes. * * @param array $classes List of classes to add - * @param boolean $toggle Add classes + * @param bool $toggle Add classes * @return $this */ public function toggleClasses( array $classes, $toggle = null ) { @@ -253,7 +253,7 @@ /** * Enable widget for client-side infusion. * - * @param boolean $infusable True to allow tag/element/widget to be referenced client-side. + * @param bool $infusable True to allow tag/element/widget to be referenced client-side. * @return $this */ public function setInfusable( $infusable ) { @@ -264,7 +264,7 @@ /** * Get client-side infusability. * - * @return boolean If this tag/element/widget can be referenced client-side. + * @return bool If this tag/element/widget can be referenced client-side. */ public function isInfusable() { return $this->infusable; @@ -345,7 +345,7 @@ * distinguish them from malformed absolute ones (again, very lax rules for parsing protocols). * * @param string $url URL - * @return boolean [description] + * @return bool [description] */ public static function isSafeUrl( $url ) { // Keep this function in sync with OO.ui.isSafeUrl diff --git a/oojs/oojs-ui/php/Widget.php b/oojs/oojs-ui/php/Widget.php index 13b937a..1936414 100644 --- a/oojs/oojs-ui/php/Widget.php +++ b/oojs/oojs-ui/php/Widget.php @@ -22,7 +22,7 @@ /** * @param array $config Configuration options - * @param boolean $config['disabled'] Disable (default: false) + * @param bool $config['disabled'] Disable (default: false) */ public function __construct( array $config = [] ) { // Initialize config @@ -39,7 +39,7 @@ /** * Check if the widget is disabled. * - * @return boolean Button is disabled + * @return bool Button is disabled */ public function isDisabled() { return $this->disabled; @@ -50,7 +50,7 @@ * * This should probably change the widgets' appearance and prevent it from being used. * - * @param boolean $disabled Disable widget + * @param bool $disabled Disable widget * @return $this */ public function setDisabled( $disabled ) { diff --git a/oojs/oojs-ui/php/layouts/PanelLayout.php b/oojs/oojs-ui/php/layouts/PanelLayout.php index 00a4cb5..83ad87c 100644 --- a/oojs/oojs-ui/php/layouts/PanelLayout.php +++ b/oojs/oojs-ui/php/layouts/PanelLayout.php @@ -8,11 +8,11 @@ class PanelLayout extends Layout { /** * @param array $config Configuration options - * @param boolean $config['scrollable'] Allow vertical scrolling (default: false) - * @param boolean $config['padded'] Pad the content from the edges (default: false) - * @param boolean $config['expanded'] Expand size to fill the entire parent element + * @param bool $config['scrollable'] Allow vertical scrolling (default: false) + * @param bool $config['padded'] Pad the content from the edges (default: false) + * @param bool $config['expanded'] Expand size to fill the entire parent element * (default: true) - * @param boolean $config['framed'] Wrap in a frame to visually separate from outside content + * @param bool $config['framed'] Wrap in a frame to visually separate from outside content * (default: false) */ public function __construct( array $config = [] ) { diff --git a/oojs/oojs-ui/php/mixins/ButtonElement.php b/oojs/oojs-ui/php/mixins/ButtonElement.php index 3ecf8e6..eaf0651 100644 --- a/oojs/oojs-ui/php/mixins/ButtonElement.php +++ b/oojs/oojs-ui/php/mixins/ButtonElement.php @@ -26,7 +26,7 @@ /** * @param array $config Configuration options - * @param boolean $config['framed'] Render button with a frame (default: true) + * @param bool $config['framed'] Render button with a frame (default: true) */ public function initializeButtonElement( array $config = [] ) { // Properties @@ -58,7 +58,7 @@ /** * Toggle frame. * - * @param boolean $framed Make button framed, omit to toggle + * @param bool $framed Make button framed, omit to toggle * @return $this */ public function toggleFramed( $framed = null ) { @@ -71,7 +71,7 @@ /** * Check if button has a frame. * - * @return boolean Button is framed + * @return bool Button is framed */ public function isFramed() { return $this->framed; diff --git a/oojs/oojs-ui/php/mixins/FlaggedElement.php b/oojs/oojs-ui/php/mixins/FlaggedElement.php index bf84e7f..1e2b5da 100644 --- a/oojs/oojs-ui/php/mixins/FlaggedElement.php +++ b/oojs/oojs-ui/php/mixins/FlaggedElement.php @@ -46,7 +46,7 @@ * Check if a flag is set. * * @param string $flag Name of flag - * @return boolean Has flag + * @return bool Has flag */ public function hasFlag( $flag ) { return isset( $this->flags[$flag] ); diff --git a/oojs/oojs-ui/php/mixins/GroupElement.php b/oojs/oojs-ui/php/mixins/GroupElement.php index 2cfeef7..a6335c7 100644 --- a/oojs/oojs-ui/php/mixins/GroupElement.php +++ b/oojs/oojs-ui/php/mixins/GroupElement.php @@ -35,7 +35,7 @@ /** * Check if there are no items. * - * @return boolean Group is empty + * @return bool Group is empty */ public function isEmpty() { return !count( $this->items ); diff --git a/oojs/oojs-ui/php/widgets/ButtonInputWidget.php b/oojs/oojs-ui/php/widgets/ButtonInputWidget.php index da96dc7..b356f7c 100644 --- a/oojs/oojs-ui/php/widgets/ButtonInputWidget.php +++ b/oojs/oojs-ui/php/widgets/ButtonInputWidget.php @@ -30,7 +30,7 @@ * @param array $config Configuration options * @param string $config['type'] HTML tag `type` attribute, may be 'button', 'submit' or 'reset' * (default: 'button') - * @param boolean $config['useInputTag'] Whether to use `<input>` rather than `<button>`. Only + * @param bool $config['useInputTag'] Whether to use `<input>` rather than `<button>`. Only * useful if you need IE 6 support in a form with multiple buttons. If you use this option, * icons and indicators will not be displayed, it won't be possible to have a non-plaintext * label, and it won't be possible to set a value (which will internally become identical to the diff --git a/oojs/oojs-ui/php/widgets/ButtonWidget.php b/oojs/oojs-ui/php/widgets/ButtonWidget.php index fcaa205..1312ca9 100644 --- a/oojs/oojs-ui/php/widgets/ButtonWidget.php +++ b/oojs/oojs-ui/php/widgets/ButtonWidget.php @@ -53,10 +53,10 @@ /** * @param array $config Configuration options - * @param boolean $config['active'] Whether button should be shown as active (default: false) + * @param bool $config['active'] Whether button should be shown as active (default: false) * @param string $config['href'] Hyperlink to visit when clicked * @param string $config['target'] Target to open hyperlink in - * @param boolean $config['noFollow'] Search engine traversal hint (default: true) + * @param bool $config['noFollow'] Search engine traversal hint (default: true) */ public function __construct( array $config = [] ) { // Parent constructor @@ -108,7 +108,7 @@ /** * Get search engine traversal hint. * - * @return boolean Whether search engines should avoid traversing this hyperlink + * @return bool Whether search engines should avoid traversing this hyperlink */ public function getNoFollow() { return $this->noFollow; @@ -164,7 +164,7 @@ /** * Set search engine traversal hint. * - * @param boolean $noFollow True if search engines should avoid traversing this hyperlink + * @param bool $noFollow True if search engines should avoid traversing this hyperlink * @return $this */ public function setNoFollow( $noFollow ) { @@ -184,7 +184,7 @@ * * A button should be marked as active when clicking it would only refresh the page. * - * @param boolean $active Make button active + * @param bool $active Make button active * @return $this */ public function setActive( $active = null ) { @@ -196,7 +196,7 @@ /** * Check if button is active. * - * @return boolean Button is active + * @return bool Button is active */ public function isActive() { return $this->active; diff --git a/oojs/oojs-ui/php/widgets/CheckboxInputWidget.php b/oojs/oojs-ui/php/widgets/CheckboxInputWidget.php index 4b0beb9..3b69497 100644 --- a/oojs/oojs-ui/php/widgets/CheckboxInputWidget.php +++ b/oojs/oojs-ui/php/widgets/CheckboxInputWidget.php @@ -22,7 +22,7 @@ /** * @param array $config Configuration options - * @param boolean $config['selected'] Whether the checkbox is initially selected + * @param bool $config['selected'] Whether the checkbox is initially selected * (default: false) */ public function __construct( array $config = [] ) { @@ -43,7 +43,7 @@ /** * Set selection state of this checkbox. * - * @param boolean $state Whether the checkbox is selected + * @param bool $state Whether the checkbox is selected * @return $this */ public function setSelected( $state ) { @@ -59,7 +59,7 @@ /** * Check if this checkbox is selected. * - * @return boolean Checkbox is selected + * @return bool Checkbox is selected */ public function isSelected() { return $this->selected; diff --git a/oojs/oojs-ui/php/widgets/ProgressBarWidget.php b/oojs/oojs-ui/php/widgets/ProgressBarWidget.php index e49ea20..e7906c8 100644 --- a/oojs/oojs-ui/php/widgets/ProgressBarWidget.php +++ b/oojs/oojs-ui/php/widgets/ProgressBarWidget.php @@ -15,7 +15,7 @@ /** * @param array $config Configuration options - * @param bool|int $config['progress'] Numeric value between 0 and 100 (the percent complete) + * @param boolean|int $config['progress'] Numeric value between 0 and 100 (the percent complete) * for determinate progress bar, or `false` for indeterminate progress bar (default: false) */ public function __construct( array $config = [] ) { @@ -44,7 +44,7 @@ } /** - * @param bool|int $progress Numeric value between 0 and 100 (the percent complete) + * @param boolean|int $progress Numeric value between 0 and 100 (the percent complete) * for determinate progress bar, or `false` for indeterminate progress bar (default: false) */ public function setProgress( $progress ) { diff --git a/oojs/oojs-ui/php/widgets/RadioInputWidget.php b/oojs/oojs-ui/php/widgets/RadioInputWidget.php index 72943d8..5f96a01 100644 --- a/oojs/oojs-ui/php/widgets/RadioInputWidget.php +++ b/oojs/oojs-ui/php/widgets/RadioInputWidget.php @@ -13,7 +13,7 @@ /** * @param array $config Configuration options - * @param boolean $config['selected'] Whether the radio button is initially selected + * @param bool $config['selected'] Whether the radio button is initially selected * (default: false) */ public function __construct( array $config = [] ) { @@ -34,7 +34,7 @@ /** * Set selection state of this radio button. * - * @param boolean $state Whether the button is selected + * @param bool $state Whether the button is selected * @return $this */ public function setSelected( $state ) { @@ -50,7 +50,7 @@ /** * Check if this radio button is selected. * - * @return boolean Radio is selected + * @return bool Radio is selected */ public function isSelected() { return $this->input->getAttribute( 'checked' ) === 'checked'; diff --git a/oojs/oojs-ui/php/widgets/TextInputWidget.php b/oojs/oojs-ui/php/widgets/TextInputWidget.php index 885c155..37ed3e1 100644 --- a/oojs/oojs-ui/php/widgets/TextInputWidget.php +++ b/oojs/oojs-ui/php/widgets/TextInputWidget.php @@ -48,15 +48,15 @@ * - `search`: implies `icon: 'search'` and `indicator: 'clear'`; when clicked, the indicator * empties the text field * @param string $config['placeholder'] Placeholder text - * @param boolean $config['autofocus'] Ask the browser to focus this widget, using the 'autofocus' + * @param bool $config['autofocus'] Ask the browser to focus this widget, using the 'autofocus' * HTML attribute (default: false) - * @param boolean $config['readOnly'] Prevent changes (default: false) + * @param bool $config['readOnly'] Prevent changes (default: false) * @param number $config['maxLength'] Maximum allowed number of characters to input - * @param boolean $config['multiline'] Allow multiple lines of text (default: false) + * @param bool $config['multiline'] Allow multiple lines of text (default: false) * @param int $config['rows'] If multiline, number of visible lines in textarea - * @param boolean $config['required'] Mark the field as required. + * @param bool $config['required'] Mark the field as required. * Implies `indicator: 'required'`. (default: false) - * @param boolean $config['autocomplete'] If the field should support autocomplete + * @param bool $config['autocomplete'] If the field should support autocomplete * or not (default: true) */ public function __construct( array $config = [] ) { @@ -115,7 +115,7 @@ /** * Check if the widget is read-only. * - * @return boolean + * @return bool */ public function isReadOnly() { return $this->readOnly; @@ -125,7 +125,7 @@ * Set the read-only state of the widget. This should probably change the widget's appearance and * prevent it from being used. * - * @param boolean $state Make input read-only + * @param bool $state Make input read-only * @return $this */ public function setReadOnly( $state ) { @@ -141,7 +141,7 @@ /** * Check if the widget is required. * - * @return boolean + * @return bool */ public function isRequired() { return $this->required; @@ -150,7 +150,7 @@ /** * Set the required state of the widget. * - * @param boolean $state Make input required + * @param bool $state Make input required * @return $this */ public function setRequired( $state ) { @@ -196,7 +196,7 @@ /** * Check if input supports multiple lines. * - * @return boolean + * @return bool */ public function isMultiline() { return (bool)$this->multiline; -- To view, visit https://gerrit.wikimedia.org/r/373152 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icf08f8c12d91b74425df319e69df22330c7088a9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/vendor Gerrit-Branch: master Gerrit-Owner: VolkerE <volke...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
