jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/373405 )
Change subject: Fix inconsistent image loading on older APIs. ...................................................................... Fix inconsistent image loading on older APIs. Aha, here's the real culprit: We were setting progressiveRendering to true (without any clear reason), and because we set it to true inside our face-detecting custom view, which uses a postprocessor, it's possible that the postprocessing gets invoked before the actual bitmap is fully loaded, causing it to fall into a funky state. Let's hope this fixes it definitively. I definitely can no longer reproduce the issue on my devices. Bug: T173896 Change-Id: I9a2c42d2f2f68a0c62c9790204c705b8710ac198 --- M app/src/main/java/org/wikipedia/gallery/ImagePipelineBitmapGetter.java M app/src/main/java/org/wikipedia/views/FaceAndColorDetectImageView.java 2 files changed, 0 insertions(+), 2 deletions(-) Approvals: jenkins-bot: Verified Mholloway: Looks good to me, approved diff --git a/app/src/main/java/org/wikipedia/gallery/ImagePipelineBitmapGetter.java b/app/src/main/java/org/wikipedia/gallery/ImagePipelineBitmapGetter.java index 4d1b149..74c601d 100644 --- a/app/src/main/java/org/wikipedia/gallery/ImagePipelineBitmapGetter.java +++ b/app/src/main/java/org/wikipedia/gallery/ImagePipelineBitmapGetter.java @@ -34,7 +34,6 @@ public void get() { ImageRequest request = ImageRequestBuilder.newBuilderWithSource(Uri.parse(imageUrl)) - .setProgressiveRenderingEnabled(true) .build(); ImagePipeline imagePipeline = Fresco.getImagePipeline(); DataSource<CloseableReference<CloseableImage>> dataSource diff --git a/app/src/main/java/org/wikipedia/views/FaceAndColorDetectImageView.java b/app/src/main/java/org/wikipedia/views/FaceAndColorDetectImageView.java index f3b18a0..27cc5d6 100644 --- a/app/src/main/java/org/wikipedia/views/FaceAndColorDetectImageView.java +++ b/app/src/main/java/org/wikipedia/views/FaceAndColorDetectImageView.java @@ -47,7 +47,6 @@ return; } ImageRequest request = ImageRequestBuilder.newBuilderWithSource(uri) - .setProgressiveRenderingEnabled(true) .setPostprocessor(new FacePostprocessor(listener)) .build(); DraweeController controller = Fresco.newDraweeControllerBuilder() -- To view, visit https://gerrit.wikimedia.org/r/373405 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a2c42d2f2f68a0c62c9790204c705b8710ac198 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Dbrant <dbr...@wikimedia.org> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: Cooltey <cf...@wikimedia.org> Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org> Gerrit-Reviewer: Sharvaniharan <sha...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits