Lucas Werkmeister (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373858 )
Change subject: Propagate statementview changes to subwidgets
......................................................................
Propagate statementview changes to subwidgets
This is required to have snak hashes in the DOM, since the subwidgets
need to get the new snak hash.
Bug: T171725
Change-Id: Icaed0bf516cbb0467e5d642226a36191fbde440c
---
M view/resources/jquery/wikibase/jquery.wikibase.statementview.js
1 file changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/58/373858/1
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
index a50616d..0850939 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
@@ -723,7 +723,18 @@
this.element.addClass(
'wikibase-statement-' + value.getClaim().getGuid() );
}
- // FIXME: Propagate external changes to all
sub-widgets? Not needed at the moment.
+ if ( this._mainSnakSnakView &&
value.getClaim().getMainSnak() ) {
+ this._mainSnakSnakView.option( key,
value.getClaim().getMainSnak() );
+ }
+ if ( this._qualifiers &&
value.getClaim().getQualifiers() ) {
+ this._qualifiers.option( key,
value.getClaim().getQualifiers() );
+ }
+ if ( this._rankSelector ) {
+ this._rankSelector.option( key,
value.getRank() );
+ }
+ if ( this._referencesListview &&
value.getReferences() ) {
+ this._referencesListview.option( key,
value.getReferences() );
+ }
}
return response;
--
To view, visit https://gerrit.wikimedia.org/r/373858
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icaed0bf516cbb0467e5d642226a36191fbde440c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
