Faidon Liambotis has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370487 )

Change subject: Add SPF and DKIM perl package requires to spamassassin class
......................................................................


Add SPF and DKIM perl package requires to spamassassin class

This will install perl dependencies (libmail-spf-perl libmail-dkim-perl)
of the SPF and DKIM plugins which are enabled in the configuration deployed
by puppet class spamassassin.

Fixes module not installed errors in spamassassin similar to:
dbg: diag: [...] module not installed: Mail::SPF ('require' failed)
dbg: diag: [...] module not installed: Mail::DKIM ('require' failed)

Bug: T172689
Bug: T172299
Change-Id: Ic4ce8c45fa9a1f013a94a8a4d06579b1fc7da544
---
M modules/spamassassin/manifests/init.pp
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Faidon Liambotis: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/spamassassin/manifests/init.pp 
b/modules/spamassassin/manifests/init.pp
index a4ca43a..f06221a 100644
--- a/modules/spamassassin/manifests/init.pp
+++ b/modules/spamassassin/manifests/init.pp
@@ -63,6 +63,8 @@
         ensure => present,
     }
 
+    require_package('libmail-spf-perl', 'libmail-dkim-perl')
+
     file { '/etc/spamassassin/local.cf':
         content => template('spamassassin/local.cf'),
         owner   => 'root',

-- 
To view, visit https://gerrit.wikimedia.org/r/370487
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4ce8c45fa9a1f013a94a8a4d06579b1fc7da544
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Herron <kher...@wikimedia.org>
Gerrit-Reviewer: Faidon Liambotis <fai...@wikimedia.org>
Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org>
Gerrit-Reviewer: Herron <kher...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to