Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374405 )
Change subject: Drop Android2 check for search
......................................................................
Drop Android2 check for search
Android2 is a grade C browser so this code will never be run in
MediaWiki.
Change-Id: I184df4fbea3743d54b24e3782c4d1debf7ff9095
---
M resources/skins.minerva.scripts/search.js
1 file changed, 8 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue
refs/changes/05/374405/1
diff --git a/resources/skins.minerva.scripts/search.js
b/resources/skins.minerva.scripts/search.js
index 10d73ee..6bbdf9c 100644
--- a/resources/skins.minerva.scripts/search.js
+++ b/resources/skins.minerva.scripts/search.js
@@ -39,18 +39,13 @@
return;
}
- // See https://phabricator.wikimedia.org/T76882 for why we disable
search on Android 2
- if ( browser.isAndroid2() ) {
- $( 'body' ).addClass( 'client-use-basic-search' );
- } else {
- // don't use focus event
(https://bugzilla.wikimedia.org/show_bug.cgi?id=47499)
- //
- // focus() (see SearchOverlay#show) opens virtual keyboard only
if triggered
- // from user context event, so using it in route callback won't
work
- //
http://stackoverflow.com/questions/6837543/show-virtual-keyboard-on-mobile-phones-in-javascript
- $( '#searchInput, #searchIcon' ).on( 'click', openSearchOverlay
)
- // Apparently needed for main menu to work correctly.
- .prop( 'readonly', true );
- }
+ // don't use focus event
(https://bugzilla.wikimedia.org/show_bug.cgi?id=47499)
+ //
+ // focus() (see SearchOverlay#show) opens virtual keyboard only if
triggered
+ // from user context event, so using it in route callback won't work
+ //
http://stackoverflow.com/questions/6837543/show-virtual-keyboard-on-mobile-phones-in-javascript
+ $( '#searchInput, #searchIcon' ).on( 'click', openSearchOverlay )
+ // Apparently needed for main menu to work correctly.
+ .prop( 'readonly', true );
}( mw.mobileFrontend, jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/374405
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I184df4fbea3743d54b24e3782c4d1debf7ff9095
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
