Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/54468
Change subject: acessor for MediaWikiTestCase::useTemporaryTables ...................................................................... acessor for MediaWikiTestCase::useTemporaryTables useTemporaryTables is marked private to prevent child from overriding the value which would cause a lot of madness whenever it forgot to reset its status. But that in turns prevents a child class from figuring out whether we use temporary tables or not. The ActiveAbstract extension test suite has such a requirement and hence need a proper accessor. MediaWikiTestCase::usesTemporaryTables() is a public accessor to for the private property MediaWikiTestCase::$useTemporaryTables. Change-Id: I8016c49116a187d7523cc0d6190514f8a513eafb --- M tests/phpunit/MediaWikiTestCase.php 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/68/54468/1 diff --git a/tests/phpunit/MediaWikiTestCase.php b/tests/phpunit/MediaWikiTestCase.php index 51fbff1..7e6e0ab 100644 --- a/tests/phpunit/MediaWikiTestCase.php +++ b/tests/phpunit/MediaWikiTestCase.php @@ -123,6 +123,10 @@ } } + function usesTemporaryTables() { + return self::$useTemporaryTables; + } + /** * obtains a new temporary file name * -- To view, visit https://gerrit.wikimedia.org/r/54468 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8016c49116a187d7523cc0d6190514f8a513eafb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Hashar <has...@free.fr> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits