jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/374790 )
Change subject: Explicitly set ecmaVersion for eslint ...................................................................... Explicitly set ecmaVersion for eslint Before, because of the use of sourceType: "module", ecmaVersion would be assumed to be ES2015, but we write ES5 here at the moment. This enables linting against ES2015 features like let and const. See https://gerrit.wikimedia.org/r/#/c/374789/ for failing POC. Change-Id: Id1d147866c37de3794213378a5e8a08af6f796a1 --- M .eslintrc.json 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: jenkins-bot: Verified Jdlrobson: Looks good to me, approved diff --git a/.eslintrc.json b/.eslintrc.json index 3c26f9e..c040a42 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -1,7 +1,8 @@ { "extends": "wikimedia", "parserOptions": { - "sourceType": "module" + "sourceType": "module", + "ecmaVersion": "5" }, "env": { "browser": true, -- To view, visit https://gerrit.wikimedia.org/r/374790 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1d147866c37de3794213378a5e8a08af6f796a1 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Jhernandez <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: Niedzielski <[email protected]> Gerrit-Reviewer: Pmiazga <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
