Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374918 )
Change subject: Chore: lower Prettier violations to warnings
......................................................................
Chore: lower Prettier violations to warnings
Reduce Prettier style offenses to warnings, not errors. Errors should
be reserved for in-your-face, don't compile, it's too dangerous to
continue type problems not whitespace concerns. Since we forbid warnings
on master, this has no impact to the end result but does allow for quick
functional iteration with styles resolution reserved for a final
`npm -s run format` pass.
Syntax note: also replace all priority codes (0-2) with text (`off`,
`warn`, or `erorr`) for consistency.
Change-Id: Ie53037c0f651f1e7ec6d1489435d9915d50a5482
---
M .eslintrc.json
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/marvin refs/changes/18/374918/1
diff --git a/.eslintrc.json b/.eslintrc.json
index 25c8bbd..55ca5e1 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -7,9 +7,9 @@
"prettier"
],
"rules": {
- "prettier/prettier": "error",
+ "prettier/prettier": "warn",
"max-len": [
- 1,
+ "warn",
{
"tabWidth": 2,
"ignoreUrls": true,
@@ -35,14 +35,14 @@
"files": [ "*.ts", "*.tsx" ],
"rules": {
// Unnecessary for a typed language.
- "jsdoc/require-returns-type": 0,
+ "jsdoc/require-returns-type": "off",
// Disable rules with known issues.
// https://github.com/eslint/typescript-eslint-parser#known-issues
- "no-undef": 0,
- "no-unused-vars": 0,
- "no-useless-constructor": 0,
- "space-infix-ops": 0
+ "no-undef": "off",
+ "no-unused-vars": "off",
+ "no-useless-constructor": "off",
+ "space-infix-ops": "off"
}
}
]
--
To view, visit https://gerrit.wikimedia.org/r/374918
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie53037c0f651f1e7ec6d1489435d9915d50a5482
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
