[MediaWiki-commits] [Gerrit] oojs/ui[master]: SelectFileWidget: Rename getTargetItem to findTargetItem

[Prtksxna (Code Review)]

Prtksxna has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/375938 )

Change subject: SelectFileWidget: Rename getTargetItem to findTargetItem
......................................................................

SelectFileWidget: Rename getTargetItem to findTargetItem

No need for deprecation or breaking change since this is
a private method that is not being used anywhere else.

Bug: T76630
Change-Id: I94484278600c5dd1a0e12de7989c04a8057a93c7
---
M src/widgets/SelectWidget.js
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/38/375938/1

diff --git a/src/widgets/SelectWidget.js b/src/widgets/SelectWidget.js
index cc6a700..7d45ef9 100644
--- a/src/widgets/SelectWidget.js
+++ b/src/widgets/SelectWidget.js
@@ -158,7 +158,7 @@
        } else {
                // One of the options got focussed (and the event bubbled up 
here).
                // They can't be tabbed to, but they can be activated using 
accesskeys.
-               item = this.getTargetItem( event );
+               item = this.findTargetItem( event );
        }
 
        if ( item ) {
@@ -185,7 +185,7 @@
 
        if ( !this.isDisabled() && e.which === OO.ui.MouseButtons.LEFT ) {
                this.togglePressed( true );
-               item = this.getTargetItem( e );
+               item = this.findTargetItem( e );
                if ( item && item.isSelectable() ) {
                        this.pressItem( item );
                        this.selecting = item;
@@ -207,7 +207,7 @@
 
        this.togglePressed( false );
        if ( !this.selecting ) {
-               item = this.getTargetItem( e );
+               item = this.findTargetItem( e );
                if ( item && item.isSelectable() ) {
                        this.selecting = item;
                }
@@ -234,7 +234,7 @@
        var item;
 
        if ( !this.isDisabled() && this.pressed ) {
-               item = this.getTargetItem( e );
+               item = this.findTargetItem( e );
                if ( item && item !== this.selecting && item.isSelectable() ) {
                        this.pressItem( item );
                        this.selecting = item;
@@ -254,7 +254,7 @@
                return;
        }
        if ( !this.isDisabled() ) {
-               item = this.getTargetItem( e );
+               item = this.findTargetItem( e );
                this.highlightItem( item && item.isHighlightable() ? item : 
null );
        }
        return false;
@@ -507,7 +507,7 @@
  * @param {jQuery.Event} e
  * @return {OO.ui.OptionWidget|null} Outline item widget, `null` if none was 
found
  */
-OO.ui.SelectWidget.prototype.getTargetItem = function ( e ) {
+OO.ui.SelectWidget.prototype.findTargetItem = function ( e ) {
        return $( e.target ).closest( '.oo-ui-optionWidget' ).data( 
'oo-ui-optionWidget' ) || null;
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/375938
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I94484278600c5dd1a0e12de7989c04a8057a93c7
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <psax...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits