jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/375784 )
Change subject: Check for Wikidiff2 version 0.3 NOT for 0.3.0 ...................................................................... Check for Wikidiff2 version 0.3 NOT for 0.3.0 version_compare( '0.3', '0.3.0', '>=' ) gives false, so we need to check for 0.3 since the Wikidiff2 version is defined as 0.3 in https://gerrit.wikimedia.org/r/#/c/319866/60/Wikidiff2.h Bug: T166571 Change-Id: Id6e9f402af2fab784a3db2444f201022e2d0de3e --- M includes/diff/DifferenceEngine.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Kinzler: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/diff/DifferenceEngine.php b/includes/diff/DifferenceEngine.php index 7f9af60..34f28523 100644 --- a/includes/diff/DifferenceEngine.php +++ b/includes/diff/DifferenceEngine.php @@ -918,7 +918,7 @@ $wikidiff2Version = phpversion( 'wikidiff2' ); if ( $wikidiff2Version !== false && - version_compare( $wikidiff2Version, '0.3.0', '>=' ) + version_compare( $wikidiff2Version, '0.3', '>=' ) ) { $text = wikidiff2_do_diff( $otext, -- To view, visit https://gerrit.wikimedia.org/r/375784 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6e9f402af2fab784a3db2444f201022e2d0de3e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> Gerrit-Reviewer: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de> Gerrit-Reviewer: Jkroll <johannes.kr...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
