Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376142 )
Change subject: Fix fatals and redundant arguments ...................................................................... Fix fatals and redundant arguments Bug: T174803 Change-Id: If48dda1682fced29da3353b643286c0a09e676cf (cherry picked from commit 3269e8db73dcb2d5f60060d7eacad46cdb94f291) --- M frontend/specialpages/reports/ConfiguredPages_body.php M frontend/specialpages/reports/ReviewedPages_body.php M frontend/specialpages/reports/StablePages_body.php 3 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs refs/changes/42/376142/1 diff --git a/frontend/specialpages/reports/ConfiguredPages_body.php b/frontend/specialpages/reports/ConfiguredPages_body.php index 89f9849..532a9ea 100644 --- a/frontend/specialpages/reports/ConfiguredPages_body.php +++ b/frontend/specialpages/reports/ConfiguredPages_body.php @@ -78,7 +78,7 @@ SpecialPage::getTitleFor( 'Stabilization' ), $this->msg( 'configuredpages-config' )->text(), [], - 'page=' . $title->getPrefixedUrl() + [ 'page' => $title->getPrefixedUrl() ] ); # Show which version is the default (stable or draft) if ( intval( $row->fpc_override ) ) { diff --git a/frontend/specialpages/reports/ReviewedPages_body.php b/frontend/specialpages/reports/ReviewedPages_body.php index ce91ab3..6d2fb08 100644 --- a/frontend/specialpages/reports/ReviewedPages_body.php +++ b/frontend/specialpages/reports/ReviewedPages_body.php @@ -101,7 +101,7 @@ SpecialPage::getTitleFor( 'ReviewedVersions' ), $this->msg( 'reviewedpages-all' )->text(), [], - 'page=' . $title->getPrefixedUrl() + [ 'page' => $title->getPrefixedUrl() ] ); # Link to highest tier rev $best = ''; @@ -110,7 +110,7 @@ $title, $this->msg( 'reviewedpages-best' )->text(), [], - 'stableid=best' + [ 'stableid' => 'best' ] ); $best = " [$best]"; } diff --git a/frontend/specialpages/reports/StablePages_body.php b/frontend/specialpages/reports/StablePages_body.php index 909479c..48f48af 100644 --- a/frontend/specialpages/reports/StablePages_body.php +++ b/frontend/specialpages/reports/StablePages_body.php @@ -72,18 +72,18 @@ $link = $linkRenderer->makeLink( $title ); // Helpful utility links $utilLinks = []; - $utilLinks[] = $linkRenderer->makeLink( + $utilLinks[] = $linkRenderer->makeKnownLink( $title, $this->msg( 'stablepages-config' )->text(), - [], [ 'action' => 'protect' ], 'known' ); - $utilLinks[] = $linkRenderer->makeLink( + [], [ 'action' => 'protect' ] ); + $utilLinks[] = $linkRenderer->makeKnownLink( $title, $this->msg( 'history' )->text(), - [], [ 'action' => 'history' ], 'known' ); - $utilLinks[] = $linkRenderer->makeLink( + [], [ 'action' => 'history' ] ); + $utilLinks[] = $linkRenderer->makeKnownLink( SpecialPage::getTitleFor( 'Log', 'stable' ), $this->msg( 'stable-logpage' )->text(), - [], [ 'page' => $title->getPrefixedText() ], 'known' ); + [], [ 'page' => $title->getPrefixedText() ] ); // Autoreview/review restriction level $restr = ''; if ( $row->fpc_level != '' ) { -- To view, visit https://gerrit.wikimedia.org/r/376142 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If48dda1682fced29da3353b643286c0a09e676cf Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/FlaggedRevs Gerrit-Branch: wmf/1.30.0-wmf.16 Gerrit-Owner: Chad <ch...@wikimedia.org> Gerrit-Reviewer: Matěj Suchánek <matejsuchane...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits