jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/376077 )
Change subject: Fix crashes when placeholder replacement contains references
......................................................................
Fix crashes when placeholder replacement contains references
Bug: T175059
Change-Id: I5d368f5980bf03b9e06b295168ac3ea25ad8e972
---
M modules/ui/mw.cx.ui.TranslationView.js
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ui/mw.cx.ui.TranslationView.js
b/modules/ui/mw.cx.ui.TranslationView.js
index 43b4edb..b346089 100644
--- a/modules/ui/mw.cx.ui.TranslationView.js
+++ b/modules/ui/mw.cx.ui.TranslationView.js
@@ -361,7 +361,8 @@
tx1 = ve.dm.TransactionBuilder.static.newFromRemoval( doc, pRange );
tx2 = ve.dm.TransactionBuilder.static.newFromDocumentInsertion(
doc,
- pRange.start,
+ // Position the start of tx2 at the end of tx1, to work around
T175059
+ pRange.end,
pasteDoc,
new ve.Range(
1,
--
To view, visit https://gerrit.wikimedia.org/r/376077
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d368f5980bf03b9e06b295168ac3ea25ad8e972
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Divec <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
