Samwilson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376188 )
Change subject: Add 'noglobal' preference parameter, for extensions to opt out
......................................................................
Add 'noglobal' preference parameter, for extensions to opt out
Not all extensions want their preferences to be able to be set
globally (e.g. Gadgets, where the preference contains the gadget
name that may be repeated on multiple wikis). This adds a new
boolean preference parameter 'noglobal' to make this possible.
Bug: T174099
Change-Id: I9cad21057472bee83d8146cc6992be07bc65a717
---
M includes/Hooks.php
1 file changed, 7 insertions(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GlobalPreferences
refs/changes/88/376188/1
diff --git a/includes/Hooks.php b/includes/Hooks.php
index f18f1f1..9ab9ffd 100644
--- a/includes/Hooks.php
+++ b/includes/Hooks.php
@@ -215,6 +215,13 @@
$user->getOption( '' );
}
foreach ( $prefs as $name => $info ) {
+ // Preferences can opt out of being globalized
by setting the 'noglobal' flag.
+ $hasOptedOut = ( isset( $info['noglobal'] ) &&
$info['noglobal'] === true );
+ if ( $hasOptedOut ) {
+ unset( $prefs[ $name ] );
+ continue;
+ }
+
// FIXME: This whole code section sucks
if ( !isset( $prefs["$name-global"] )
&& self::isGlobalizablePreference(
$name, $info )
--
To view, visit https://gerrit.wikimedia.org/r/376188
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9cad21057472bee83d8146cc6992be07bc65a717
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GlobalPreferences
Gerrit-Branch: master
Gerrit-Owner: Samwilson <s...@samwilson.id.au>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
