jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/376005 )

Change subject: Construct registrar_url in country table rather than 
monuments_all
......................................................................


Construct registrar_url in country table rather than monuments_all

Apart from making it easier to understand this makes the data
available for the migration tools.

Updated url in ru_ru per the corresponding property on Wikidata.

Change-Id: I9d6ed8fc054e1dc8e43c997350eecab04f3e1f65
---
M erfgoedbot/monuments_config/ar_es.json
M erfgoedbot/monuments_config/cz_cs.json
M erfgoedbot/monuments_config/ru_ru.json
3 files changed, 18 insertions(+), 6 deletions(-)

Approvals:
  Jean-Frédéric: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/erfgoedbot/monuments_config/ar_es.json 
b/erfgoedbot/monuments_config/ar_es.json
index 4442c1d..039d2cd 100644
--- a/erfgoedbot/monuments_config/ar_es.json
+++ b/erfgoedbot/monuments_config/ar_es.json
@@ -16,6 +16,7 @@
     "commonsCategoryBase": "Cultural heritage monuments in Argentina",
     "unusedImagesPage": "Wikiproyecto:Patrimonio histórico/Fotos de monumentos 
de Argentina sin usar",
     "imagesWithoutIdPage": "Wikiproyecto:Patrimonio histórico/Fotos de 
monumentos de Argentina sin id",
+    "registrantUrlBase": 
"http://www.monumentosysitios.gov.ar/ficha.php?idMonumento=%s";,
     "fields": [
         {
             "dest": "id",
@@ -75,6 +76,11 @@
         {
             "dest": "imagen",
             "source": "imagen"
+        },
+        {
+            "dest": "registrant_url",
+            "source": "id",
+            "conv": "generateRegistrantUrl"
         }
     ],
     "sql_lang": "Spanish",
@@ -149,8 +155,8 @@
             "type": "Field"
         },
         "registrant_url": {
-            "value": 
"CONCAT('http://www.monumentosysitios.gov.ar/ficha.php?idMonumento=', id)",
-            "type": "Raw"
+            "value": "registrant_url",
+            "type": "Field"
         }
     }
 }
diff --git a/erfgoedbot/monuments_config/cz_cs.json 
b/erfgoedbot/monuments_config/cz_cs.json
index 7ee7090..4b1125a 100644
--- a/erfgoedbot/monuments_config/cz_cs.json
+++ b/erfgoedbot/monuments_config/cz_cs.json
@@ -17,6 +17,7 @@
     "unusedImagesPage": "Wikipedie:WikiProjekt Wiki Loves Monuments/Nevyužité 
obrázky",
     "imagesWithoutIdPage": "User:Multichill/Images of cultural heritage 
monuments in Czech Republic without id",
     "missingCommonscatPage": "Wikipedie:WikiProjekt Wiki Loves 
Monuments/Missing commons category links",
+    "registrantUrlBase": 
"http://monumnet.npu.cz/pamfond/list.php?hledani=1&CiRejst=%s";,
     "fields": [
         {
             "dest": "id_objektu",
@@ -80,6 +81,11 @@
         {
             "dest": "remark",
             "source": "Poznámka"
+        },
+        {
+            "dest": "registrant_url",
+            "source": "Id_objektu",
+            "conv": "generateRegistrantUrl"
         }
     ],
     "sql_lang": "Czech language",
@@ -154,8 +160,8 @@
             "type": "Field"
         },
         "registrant_url": {
-            "value": 
"CONCAT('http://monumnet.npu.cz/pamfond/list.php?hledani=1&CiRejst=',`id_objektu`)",
-            "type": "Raw"
+            "value": "registrant_url",
+            "type": "Field"
         }
     }
-}
\ No newline at end of file
+}
diff --git a/erfgoedbot/monuments_config/ru_ru.json 
b/erfgoedbot/monuments_config/ru_ru.json
index ef4f5f7..06bac3b 100644
--- a/erfgoedbot/monuments_config/ru_ru.json
+++ b/erfgoedbot/monuments_config/ru_ru.json
@@ -15,7 +15,7 @@
     "commonsCategoryBase": "Cultural heritage monuments in Russia",
     "unusedImagesPage": "Культурное наследие России/Неиспользуемые 
изображения",
     "imagesWithoutIdPage": "Культурное наследие России/Изображения без ID",
-    "registrantUrlBase": "http://kulturnoe-nasledie.ru/monuments.php?id=%s";,
+    "registrantUrlBase": 
"http://old.kulturnoe-nasledie.ru/monuments.php?id=%s";,
     "fields": [
         {
             "dest": "id",

-- 
To view, visit https://gerrit.wikimedia.org/r/376005
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9d6ed8fc054e1dc8e43c997350eecab04f3e1f65
Gerrit-PatchSet: 2
Gerrit-Project: labs/tools/heritage
Gerrit-Branch: master
Gerrit-Owner: Lokal Profil <lokal.pro...@gmail.com>
Gerrit-Reviewer: Jean-Frédéric <jeanfrederic.w...@gmail.com>
Gerrit-Reviewer: Multichill <maar...@mdammers.nl>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to