Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/376282 )

Change subject: Hide last modified bar on old revisions
......................................................................

Hide last modified bar on old revisions

Bug: T153125
Change-Id: I43f6f1993ebeacead12d7ec6da584c6d1e14da12
---
M includes/skins/MinervaTemplate.php
M includes/skins/SkinMinerva.php
2 files changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/82/376282/1

diff --git a/includes/skins/MinervaTemplate.php 
b/includes/skins/MinervaTemplate.php
index 4e15ec9..5458ee8 100644
--- a/includes/skins/MinervaTemplate.php
+++ b/includes/skins/MinervaTemplate.php
@@ -65,7 +65,9 @@
 
                // This turns off the footer id and allows us to distinguish 
the old footer with the new design
                return [
-                       'lastmodified' => $this->getHistoryLinkHtml( $data ),
+                       // The last modified bar is only rendered on the latest 
revision. For older revisions the last modified
+                       // information appears at the top of the page.
+                       'lastmodified' => $data['isLatestRevision'] ? 
$this->getHistoryLinkHtml( $data ) : '',
                        'headinghtml' => $data['footer-site-heading-html'],
                        // Note mobile-license is only available on the mobile 
skin. It is outputted as part of
                        // footer-info on desktop hence the conditional check.
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index e4dc7a7..82fe382 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -877,6 +877,8 @@
                        }
                }
                $tpl->set( 'headinghtml', $this->getHeadingHtml() );
+               $tpl->set( 'isLatestRevision', $this->getRevisionId() === 
$title->getLatestRevID() );
+
                $tpl->set( 'footer-site-heading-html', $this->getSitename() );
                // set defaults
                if ( !isset( $tpl->data['postbodytext'] ) ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/376282
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I43f6f1993ebeacead12d7ec6da584c6d1e14da12
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to