Subramanya Sastry has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376446 )
Change subject: WIP: Fix bug in dl-dt list output generation ...................................................................... WIP: Fix bug in dl-dt list output generation * Tidy was hiding this bug so far * TODO: Add new tests, verify. Bug: T175099 Change-Id: I6d5b225b82cecf9a43f23837ed8ec359b31aadad --- M includes/parser/BlockLevelPass.php 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/46/376446/1 diff --git a/includes/parser/BlockLevelPass.php b/includes/parser/BlockLevelPass.php index 599fbf6..35f0805 100644 --- a/includes/parser/BlockLevelPass.php +++ b/includes/parser/BlockLevelPass.php @@ -257,6 +257,11 @@ $output .= $this->nextItem( $prefix[$commonPrefixLength - 1] ); } + # Close an open <dt> if we have a <dd> (":") starting on this line + if ( $this->DTopen && substr( $prefix, $commonPrefixLength - 1, 1) === ':' ) { + $output .= $this->nextItem( ':' ); + } + # Open prefixes where appropriate. if ( $lastPrefix && $prefixLength > $commonPrefixLength ) { $output .= "\n"; -- To view, visit https://gerrit.wikimedia.org/r/376446 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6d5b225b82cecf9a43f23837ed8ec359b31aadad Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry <ssas...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits