VolkerE has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376453 )
Change subject: [DONOTMERGE] build: Use stylelint-declaration-use-variable
plugin
......................................................................
[DONOTMERGE] build: Use stylelint-declaration-use-variable plugin
Using 'stylelint-declaration-use-variable', which sounds like a good
idea, but:
- doesn't seem actively maintained,
- you can't declare which var to use when, so there are false warnings
on values like `1` for property `z-index` instead of `opacity` or
`border-color` asked on `background-color`
Change-Id: I32259f04e81f44b968a6b397d1f7e7d8c1075c03
---
M .stylelintrc
M package.json
2 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/53/376453/1
diff --git a/.stylelintrc b/.stylelintrc
index 06a77ac..0b0cee8 100644
--- a/.stylelintrc
+++ b/.stylelintrc
@@ -1,9 +1,13 @@
{
"extends": "stylelint-config-wikimedia",
+ "plugins": [
+ "stylelint-declaration-use-variable"
+ ],
"rules": {
"at-rule-empty-line-before": null,
"block-closing-brace-space-after": null,
"block-no-empty": null,
- "no-descending-specificity": null
+ "no-descending-specificity": null,
+ "sh-waqar/declaration-use-variable": [["/color/", "z-index",
"font-size"]]
}
}
diff --git a/package.json b/package.json
index 808e454..6152638 100644
--- a/package.json
+++ b/package.json
@@ -25,6 +25,7 @@
"dependencies": {
"jquery": "3.2.1",
"oojs": "2.1.0",
+ "stylelint-declaration-use-variable": "^1.6.0",
"wikimedia-ui-base": "0.9.2"
},
"devDependencies": {
--
To view, visit https://gerrit.wikimedia.org/r/376453
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I32259f04e81f44b968a6b397d1f7e7d8c1075c03
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
