Ottomata has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/376563 )
Change subject: Disable validating request-id while working on a fix
......................................................................
Disable validating request-id while working on a fix
Change-Id: Ic488fea9c754a950c57d74a7ded605795942bf2c
---
M jsonschema/mediawiki/job/1.yaml
M test/jsonschema/meta_common_schema.yaml
2 files changed, 6 insertions(+), 2 deletions(-)
Approvals:
Ottomata: Looks good to me, approved
jenkins-bot: Verified
diff --git a/jsonschema/mediawiki/job/1.yaml b/jsonschema/mediawiki/job/1.yaml
index 630df4a..237e42c 100644
--- a/jsonschema/mediawiki/job/1.yaml
+++ b/jsonschema/mediawiki/job/1.yaml
@@ -25,7 +25,9 @@
request_id:
description: The unique UUID v1 ID of the event derived from the
X-Request-Id header.
type: string
- pattern: '^[a-fA-F0-9]{8}(-[a-fA-F0-9]{4}){3}-[a-fA-F0-9]{12}$'
+ # TODO: Temporary disable this validation requirement while working on
a proper fix
+ # because it's causing an alert.
+ #pattern: '^[a-fA-F0-9]{8}(-[a-fA-F0-9]{4}){3}-[a-fA-F0-9]{12}$'
id:
description: The unique ID of this event; should match the dt field.
type: string
diff --git a/test/jsonschema/meta_common_schema.yaml
b/test/jsonschema/meta_common_schema.yaml
index c304170..40fcdac 100644
--- a/test/jsonschema/meta_common_schema.yaml
+++ b/test/jsonschema/meta_common_schema.yaml
@@ -22,7 +22,9 @@
description: the unique URI identifying the event / resource
request_id:
type: string
- pattern: '^[a-fA-F0-9]{8}(-[a-fA-F0-9]{4}){3}-[a-fA-F0-9]{12}$'
+ # TODO: Temporary disable this validation requirement while working on
a proper fix
+ # because it's causing an alert.
+ #pattern: '^[a-fA-F0-9]{8}(-[a-fA-F0-9]{4}){3}-[a-fA-F0-9]{12}$'
description: the unique UUID v1 ID of the event derived from the
X-Request-Id header
id:
type: string
--
To view, visit https://gerrit.wikimedia.org/r/376563
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic488fea9c754a950c57d74a7ded605795942bf2c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/event-schemas
Gerrit-Branch: master
Gerrit-Owner: Ppchelko <ppche...@wikimedia.org>
Gerrit-Reviewer: Ottomata <ao...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
