Mattflaschen has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376794 )
Change subject: WIP: RCFilters: Keep the default for replaced filters, but
allow override
......................................................................
WIP: RCFilters: Keep the default for replaced filters, but allow override
E.g. hidenondamaging (ORES legacy) always defaults to false if you are
using the new UI, regardless of preferences.
However, before 6314a9026f9b404928e96a883c6ace7e491e891b you
could still override this.
Bug: T162158
Change-Id: I27302664ec3baec319814cf0e80d02172b2b1a86
---
M includes/changes/ChangesListBooleanFilter.php
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/94/376794/1
diff --git a/includes/changes/ChangesListBooleanFilter.php
b/includes/changes/ChangesListBooleanFilter.php
index de5faaa..6d420c9 100644
--- a/includes/changes/ChangesListBooleanFilter.php
+++ b/includes/changes/ChangesListBooleanFilter.php
@@ -252,10 +252,6 @@
* @return bool Whether this filter should be considered active
*/
public function isActive( FormOptions $opts, $isStructuredUI ) {
- if ( $this->isReplacedInStructuredUi && $isStructuredUI ) {
- return false;
- }
-
return $opts[ $this->getName() ] === $this->activeValue;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/376794
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I27302664ec3baec319814cf0e80d02172b2b1a86
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
