Giuseppe Lavagetto has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/377439 )
Change subject: statsd_proxy: use validate_numeric()
......................................................................
statsd_proxy: use validate_numeric()
Use validate_numeric() to validate the $server_port parameter as a
numeric and the $backend_ports parameter as an array of numerics,
instead of trying to validate them with regular expressions. Validating
Integers against REs breaks with the future parser and this is easier to
read anyway.
Change-Id: I9cf253bf84231767d064b39a306690f79f2f6c4b
---
M modules/statsd_proxy/manifests/init.pp
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Giuseppe Lavagetto: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/statsd_proxy/manifests/init.pp
b/modules/statsd_proxy/manifests/init.pp
index 0a2f98e..793c0ac 100644
--- a/modules/statsd_proxy/manifests/init.pp
+++ b/modules/statsd_proxy/manifests/init.pp
@@ -33,8 +33,8 @@
) {
validate_ensure($ensure)
validate_array($backend_ports)
- validate_re(join($backend_ports, ' '), '^\d+( \d+)*$', '$backend_ports
must be an array of port numbers')
- validate_re($server_port, '^\d+$', '$server_port must be a port number')
+ validate_numeric($backend_ports)
+ validate_numeric($server_port)
package { 'statsd-proxy':
ensure => $ensure,
--
To view, visit https://gerrit.wikimedia.org/r/377439
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9cf253bf84231767d064b39a306690f79f2f6c4b
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis <fai...@wikimedia.org>
Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
