jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/377754 )
Change subject: Fix lazy-loading of images upon first render.
......................................................................
Fix lazy-loading of images upon first render.
An explicit call to loadPlaceholders() got lost during the upgrade to use
XHR for loading the remaining sections.
Bug: T175579
Change-Id: I9cfbbeda8339e25f3020f3752040c83869fd3ee0
---
M app/src/main/assets/bundle.js
M www/js/sections.js
2 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
jenkins-bot: Verified
Mholloway: Looks good to me, approved
diff --git a/app/src/main/assets/bundle.js b/app/src/main/assets/bundle.js
index 6d1c3c2..7f2e681 100644
--- a/app/src/main/assets/bundle.js
+++ b/app/src/main/assets/bundle.js
@@ -377,6 +377,7 @@
if (!issuesContainer.hasChildNodes()) {
document.getElementById( "content" ).removeChild(issuesContainer);
}
+ lazyLoadTransformer.loadPlaceholders();
});
function clearContents() {
@@ -464,6 +465,7 @@
window.scrollTo( 0, scrollY );
}
document.getElementById( "loading_sections").className = "";
+ lazyLoadTransformer.loadPlaceholders();
bridge.sendMessage( "pageLoadComplete", { "sequence": sequence });
}
diff --git a/www/js/sections.js b/www/js/sections.js
index de3be6c..34492f8 100644
--- a/www/js/sections.js
+++ b/www/js/sections.js
@@ -134,6 +134,7 @@
if (!issuesContainer.hasChildNodes()) {
document.getElementById( "content" ).removeChild(issuesContainer);
}
+ lazyLoadTransformer.loadPlaceholders();
});
function clearContents() {
@@ -221,6 +222,7 @@
window.scrollTo( 0, scrollY );
}
document.getElementById( "loading_sections").className = "";
+ lazyLoadTransformer.loadPlaceholders();
bridge.sendMessage( "pageLoadComplete", { "sequence": sequence });
}
--
To view, visit https://gerrit.wikimedia.org/r/377754
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9cfbbeda8339e25f3020f3752040c83869fd3ee0
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Cooltey <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Sharvaniharan <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
