Jcasariego has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/377868 )
Change subject: Design tweak: Change 'Next' button color for Light and Dark
modes
......................................................................
Design tweak: Change 'Next' button color for Light and Dark modes
Change Next button color from the outdated teal color to Accent50 (Light mode)
and Accent75 (Dark mode).
Bug: T175674
Change-Id: I8302758ffa38bb764ab9417032912aca2632adf6
---
M app/src/main/java/org/wikipedia/edit/EditSectionActivity.java
M app/src/main/res/values/attrs.xml
M app/src/main/res/values/styles_dark.xml
M app/src/main/res/values/styles_light.xml
4 files changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/68/377868/1
diff --git a/app/src/main/java/org/wikipedia/edit/EditSectionActivity.java
b/app/src/main/java/org/wikipedia/edit/EditSectionActivity.java
index 77ee6a9..c6d13d1 100644
--- a/app/src/main/java/org/wikipedia/edit/EditSectionActivity.java
+++ b/app/src/main/java/org/wikipedia/edit/EditSectionActivity.java
@@ -48,6 +48,7 @@
import org.wikipedia.page.PageProperties;
import org.wikipedia.page.PageTitle;
import org.wikipedia.util.FeedbackUtil;
+import org.wikipedia.util.ResourceUtil;
import org.wikipedia.util.StringUtil;
import org.wikipedia.util.log.L;
import org.wikipedia.views.ViewAnimations;
@@ -581,7 +582,8 @@
});
v.setBackgroundColor(ContextCompat.getColor(this, item.isEnabled()
- ? (editPreviewFragment.isActive() ? R.color.accent50 :
R.color.green50) : R.color.base50));
+ ? (editPreviewFragment.isActive() ? R.color.accent50
+ : ResourceUtil.getThemedAttributeId(this,
R.attr.edit_preview)) : R.color.base50));
return true;
}
diff --git a/app/src/main/res/values/attrs.xml
b/app/src/main/res/values/attrs.xml
index 45e1c59..1ceb73e 100644
--- a/app/src/main/res/values/attrs.xml
+++ b/app/src/main/res/values/attrs.xml
@@ -44,6 +44,8 @@
<attr name="multi_select_background_color" format="reference" />
<attr name="searchItemBackground" format="reference" />
+ <attr name="edit_preview_color" format="reference" />
+
<attr name="blue_switch" format="reference" />
<declare-styleable name="CabSearchView">
diff --git a/app/src/main/res/values/styles_dark.xml
b/app/src/main/res/values/styles_dark.xml
index aae4dba..2615f00 100644
--- a/app/src/main/res/values/styles_dark.xml
+++ b/app/src/main/res/values/styles_dark.xml
@@ -78,6 +78,8 @@
<item name="cardBackgroundColor">@color/base14</item>
<item name="blue_switch">@style/BlueSwitchDark</item>
+ <item name="edit_preview_color">@color/accent75</item>
+
</style>
<style name="Theme.Dark.Dialog.Alert"
parent="Theme.AppCompat.Dialog.Alert">
diff --git a/app/src/main/res/values/styles_light.xml
b/app/src/main/res/values/styles_light.xml
index b276c94..769e30f 100644
--- a/app/src/main/res/values/styles_light.xml
+++ b/app/src/main/res/values/styles_light.xml
@@ -79,6 +79,8 @@
<item name="cardBackgroundColor">@color/base100</item>
<item name="blue_switch">@style/BlueSwitchLight</item>
+ <item name="edit_preview_color">@color/accent50</item>
+
</style>
<style name="Theme.Light.Dialog.Alert"
parent="Theme.AppCompat.Light.Dialog.Alert">
--
To view, visit https://gerrit.wikimedia.org/r/377868
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8302758ffa38bb764ab9417032912aca2632adf6
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Jcasariego <jorgek...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
