Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/378019 )

Change subject: Disable submit button when input is invalid
......................................................................

Disable submit button when input is invalid

Change-Id: Id8b3c098fc2fbec778b0d4cf98fa7cc35202d95b
---
M modules/ve-mw-collab/ve.init.mw.CollabTarget.init.js
1 file changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/19/378019/1

diff --git a/modules/ve-mw-collab/ve.init.mw.CollabTarget.init.js 
b/modules/ve-mw-collab/ve.init.mw.CollabTarget.init.js
index 4a5de31..18f2301 100644
--- a/modules/ve-mw-collab/ve.init.mw.CollabTarget.init.js
+++ b/modules/ve-mw-collab/ve.init.mw.CollabTarget.init.js
@@ -70,6 +70,14 @@
                documentNameField.toggle( true );
        }
 
+       function onChange() {
+               documentNameInput.getValidity().then( function () {
+                       submitButton.setDisabled( false );
+               }, function () {
+                       submitButton.setDisabled( true );
+               } );
+       }
+
        function onSubmit() {
                documentNameInput.getValidity().then( function () {
                        var title = mw.Title.newFromText( 
documentNameInput.getValue() ),
@@ -95,8 +103,10 @@
        } );
        submitButton.setDisabled( false );
 
+       documentNameInput.on( 'change', onChange );
        documentNameInput.on( 'enter', onSubmit );
        submitButton.on( 'click', onSubmit );
+       onChange();
 
        if ( pageTitle ) {
                showPage( pageTitle );

-- 
To view, visit https://gerrit.wikimedia.org/r/378019
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8b3c098fc2fbec778b0d4cf98fa7cc35202d95b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to