Filippo Giunchedi has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/378054 )
Change subject: imagescaler: use class-style for 3d2png
......................................................................
imagescaler: use class-style for 3d2png
The previous invocation yields this:
Error: Could not retrieve catalog from remote server: Error 400 on
SERVER: Illegal fully qualified name at
/etc/puppet/modules/role/manifests/mediawiki/imagescaler.pp:9:15
Bug: T160185
Change-Id: I4076d3e6b0065330ada38034ebb75fd5ec3a773e
---
M modules/role/manifests/mediawiki/imagescaler.pp
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Filippo Giunchedi: Looks good to me, approved
diff --git a/modules/role/manifests/mediawiki/imagescaler.pp
b/modules/role/manifests/mediawiki/imagescaler.pp
index 72851d7..b601692 100644
--- a/modules/role/manifests/mediawiki/imagescaler.pp
+++ b/modules/role/manifests/mediawiki/imagescaler.pp
@@ -6,6 +6,8 @@
include ::profile::prometheus::apache_exporter
include ::profile::prometheus::hhvm_exporter
include ::base::firewall
- include ::3d2png::deploy
+
+ # include doesn't allow names to start with numbers
+ class { '3d2png::deploy': }
}
--
To view, visit https://gerrit.wikimedia.org/r/378054
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4076d3e6b0065330ada38034ebb75fd5ec3a773e
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <[email protected]>
Gerrit-Reviewer: Filippo Giunchedi <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
