Henning Snater has submitted this change and it was merged.
Change subject: Minor performance optimization for entityview initialization
......................................................................
Minor performance optimization for entityview initialization
Take entityview widget subject out of the DOM before initializing the widget.
This will prevent all
events triggered during initialization from bubbeling higher up the DOM than
necessary. This will
give a little performance boost, especially on bigger entities. Depending on
the browser I have
measured performance improvements of up to 25%.
Change-Id: I19b17aac0c1bf198c93183791791e1c9bc4900ea
---
M repo/resources/wikibase.ui.entityViewInit.js
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Henning Snater: Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/repo/resources/wikibase.ui.entityViewInit.js
b/repo/resources/wikibase.ui.entityViewInit.js
index 849730b..d420b4d 100644
--- a/repo/resources/wikibase.ui.entityViewInit.js
+++ b/repo/resources/wikibase.ui.entityViewInit.js
@@ -108,9 +108,12 @@
// BUILD CLAIMS VIEW:
// Note: $.entityview() only works for claims right
now, the goal is to use it for more
- var $claims = $( '.wb-claims' ).entityview( {
+ var $claims = $( '.wb-claims' ).first(),
+ $claimsParent = $claims.parent();
+
+ $claims.detach().entityview( { // take widget subject
out of DOM while initializing
value: wb.entity
- } );
+ } ).appendTo( $claimsParent );
// removing site links heading to rebuild it with value
counter
$( 'table.wb-sitelinks' ).each( function() {
--
To view, visit https://gerrit.wikimedia.org/r/54855
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19b17aac0c1bf198c93183791791e1c9bc4900ea
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner <daniel.wer...@wikimedia.de>
Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
