jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/378018 )
Change subject: Fix AuthorListPopupTool's surface setting
......................................................................
Fix AuthorListPopupTool's surface setting
Change-Id: I03ff144e446117be625e59a1bacd42b3f8d279ce
---
M src/ui/tools/ve.ui.AuthorListPopupTool.js
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/src/ui/tools/ve.ui.AuthorListPopupTool.js
b/src/ui/tools/ve.ui.AuthorListPopupTool.js
index a62b263..a7238d7 100644
--- a/src/ui/tools/ve.ui.AuthorListPopupTool.js
+++ b/src/ui/tools/ve.ui.AuthorListPopupTool.js
@@ -31,8 +31,6 @@
// Events
this.toolbar.connect( this, { surfaceChange: 'onSurfaceChange' } );
- this.setup( this.toolbar.getSurface() );
-
this.$element.addClass( 've-ui-authorListPopupTool' );
};
@@ -42,8 +40,8 @@
/* Methods */
-ve.ui.AuthorListPopupTool.prototype.onSurfaceChange = function ( surface ) {
- this.setup( surface );
+ve.ui.AuthorListPopupTool.prototype.onSurfaceChange = function ( oldSurface,
newSurface ) {
+ this.setup( newSurface );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/378018
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03ff144e446117be625e59a1bacd42b3f8d279ce
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
