Hello Aaron Schulz, I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/378093 to review the following change. Change subject: Log a DB disconnect with successful reconnect at INFO ...................................................................... Log a DB disconnect with successful reconnect at INFO If we reconnected, it's not a huge deal Change-Id: I62bc3f68fcbe43532dce849d515a5e0620fba6f2 --- M includes/libs/rdbms/database/Database.php 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/93/378093/1 diff --git a/includes/libs/rdbms/database/Database.php b/includes/libs/rdbms/database/Database.php index c904092..9998313 100644 --- a/includes/libs/rdbms/database/Database.php +++ b/includes/libs/rdbms/database/Database.php @@ -946,8 +946,8 @@ $this->handleSessionLoss(); if ( $this->reconnect() ) { $msg = __METHOD__ . ": lost connection to {$this->getServer()}; reconnected"; - $this->connLogger->warning( $msg ); - $this->queryLogger->warning( + $this->connLogger->info( $msg ); + $this->queryLogger->info( "$msg:\n" . ( new RuntimeException() )->getTraceAsString() ); if ( !$recoverable ) { -- To view, visit https://gerrit.wikimedia.org/r/378093 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I62bc3f68fcbe43532dce849d515a5e0620fba6f2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Chad <ch...@wikimedia.org> Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits