jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/378269 )
Change subject: WikimediaUI theme: Improve ListToolGroup's color and opacity
handling
......................................................................
WikimediaUI theme: Improve ListToolGroup's color and opacity handling
As ListToolGroup's tool –inverse to most other widgets– gets a
lighter shade of grey as background-color on `:hover`, we want to
make sure that it follows the inverse principle of icon opacity and
color as well (all sligthly darker) and consume base variables.
Change-Id: I45a122f0cc487b61dfda0f6838d55c9a57cd55bb
---
M src/themes/wikimediaui/common.less
M src/themes/wikimediaui/tools.less
2 files changed, 3 insertions(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/src/themes/wikimediaui/common.less
b/src/themes/wikimediaui/common.less
index c96b07f..baba4bb 100644
--- a/src/themes/wikimediaui/common.less
+++ b/src/themes/wikimediaui/common.less
@@ -35,6 +35,7 @@
@background-color-tool--hover: @background-color-base--hover;
@background-color-tool--active: @background-color-progressive;
@background-color-tool--active-hover: @background-color-progressive--hover;
+@color-tool--hover: @color-base--emphasized; // Used here in combination with
`:hover` background-color turning light grey
@color-tool--active: @color-progressive;
@border-toolbar: @border-width-base solid #c8ccd1;
diff --git a/src/themes/wikimediaui/tools.less
b/src/themes/wikimediaui/tools.less
index 817c81d..a448d4c 100644
--- a/src/themes/wikimediaui/tools.less
+++ b/src/themes/wikimediaui/tools.less
@@ -178,9 +178,10 @@
&.oo-ui-widget-enabled {
&:hover {
background-color: @background-color-tool--hover;
+ color: @color-tool--hover;
.oo-ui-tool-link .oo-ui-iconElement-icon {
- opacity: 0.9;
+ opacity: @opacity-base;
}
}
}
--
To view, visit https://gerrit.wikimedia.org/r/378269
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45a122f0cc487b61dfda0f6838d55c9a57cd55bb
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
