jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/378344 )

Change subject: WikimediaUI theme: Simplify disabled tool opacity rules
......................................................................


WikimediaUI theme: Simplify disabled tool opacity rules

Simplifying tools by generalizing them into `.oo-ui-tool` and
`.oo-ui-toolGroup`.

Change-Id: I543c764b0c38b113dd16d971220b443fc2fd67cd
---
M src/themes/wikimediaui/tools.less
1 file changed, 9 insertions(+), 12 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/src/themes/wikimediaui/tools.less 
b/src/themes/wikimediaui/tools.less
index a448d4c..0d0fba0 100644
--- a/src/themes/wikimediaui/tools.less
+++ b/src/themes/wikimediaui/tools.less
@@ -75,6 +75,10 @@
                        .oo-ui-transition( color @transition-ease-quick );
                }
        }
+
+       &.oo-ui-widget-disabled .oo-ui-iconElement-icon {
+               opacity: @opacity-tool--disabled;
+       }
 }
 
 .theme-oo-ui-popupTool () {
@@ -110,6 +114,11 @@
                + .oo-ui-toolGroup {
                        margin-left: 0;
                }
+       }
+
+       &.oo-ui-widget-disabled .oo-ui-indicatorElement-indicator,
+       &.oo-ui-widget-disabled .oo-ui-iconElement-icon {
+               opacity: @opacity-tool--disabled;
        }
 }
 
@@ -209,12 +218,6 @@
        .oo-ui-tool.oo-ui-widget-disabled .oo-ui-tool-title {
                color: @color-base--disabled;
        }
-
-       &.oo-ui-widget-disabled .oo-ui-indicatorElement-indicator,
-       &.oo-ui-widget-disabled .oo-ui-iconElement-icon,
-       .oo-ui-tool.oo-ui-widget-disabled .oo-ui-iconElement-icon {
-               opacity: @opacity-tool--disabled;
-       }
 }
 
 .theme-oo-ui-menuToolGroup () {
@@ -254,12 +257,6 @@
        &.oo-ui-widget-disabled,
        .oo-ui-tool.oo-ui-widget-disabled .oo-ui-tool-title {
                color: @color-base--disabled;
-       }
-
-       &.oo-ui-widget-disabled .oo-ui-indicatorElement-indicator,
-       &.oo-ui-widget-disabled .oo-ui-iconElement-icon,
-       .oo-ui-tool.oo-ui-widget-disabled .oo-ui-iconElement-icon {
-               opacity: @opacity-tool--disabled;
        }
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/378344
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I543c764b0c38b113dd16d971220b443fc2fd67cd
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to