BearND has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/378366 )

Change subject: Make script to compile top-pages more generic
......................................................................

Make script to compile top-pages more generic

Better error handling. Check for response code.

Change-Id: Ia405c6d5a59d120431adc3a9fef374e62e3d194e
---
M scripts/measure-payloads.js
1 file changed, 9 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/66/378366/1

diff --git a/scripts/measure-payloads.js b/scripts/measure-payloads.js
index c8e9ad9..b83b070 100755
--- a/scripts/measure-payloads.js
+++ b/scripts/measure-payloads.js
@@ -89,9 +89,11 @@
     const logger = fs.createWriteStream(PAGE_FILE, { flags: 'w' });
     logger.write(`{ "items": [\n`);
     myPages.forEach((page, index, array) => {
-        const comma = (index < array.length - 1) ? ',' : '';
-        const title = page.title && page.title.replace(/"/g, '\\"');
-        logger.write(`  { "title": "${title}", "rev": "${page.rev}" 
}${comma}\n`);
+        if (page) {
+            const comma = (index < array.length - 1) ? ',' : '';
+            const title = page.title && page.title.replace(/"/g, '\\"');
+            logger.write(`  { "title": "${title}", "rev": "${page.rev}" 
}${comma}\n`);
+        }
     });
     logger.write(`]}\n`);
     logger.end();
@@ -102,6 +104,10 @@
         const cmd = `curl --head 
"${PARSOID_BASE_URI}/${fixTitleForRequest(page.title)}"`;
         return exec(cmd)
         .then((rsp) => {
+            if (!/^HTTP\/1.1 200 OK$/m.test(rsp)) {
+                process.stderr.write(`WARNING: skipping parsoid for 
${page.title}`);
+                return BBPromise.resolve();
+            }
             const etagMatch = /^ETag:\s+W\/"(\S+?)"$/m.exec(rsp);
             process.stdout.write('.');
             page.rev = etagMatch[1];

-- 
To view, visit https://gerrit.wikimedia.org/r/378366
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia405c6d5a59d120431adc3a9fef374e62e3d194e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND <bsitzm...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to