Krinkle has submitted this change and it was merged.

Change subject: Zuul: Clean up html and css.
......................................................................


Zuul: Clean up html and css.

- Whitespace
- Relative paths (so it works when testing locally from a different url)
- Drop redundant attributes
- Remove incorrect max-width on pipeline-container:
  http://cl.ly/image/0R0u0u1n0p2I
  (top: without the max-width, bottom: old version with max-width)

Change-Id: I0ddc7ceb56ebbb230c463a0367c5c454151bad1b
---
M org/wikimedia/integration/zuul/index.html
1 file changed, 74 insertions(+), 68 deletions(-)

Approvals:
  Krinkle: Verified; Looks good to me, approved



diff --git a/org/wikimedia/integration/zuul/index.html 
b/org/wikimedia/integration/zuul/index.html
index 2889fb4..29a86c1 100644
--- a/org/wikimedia/integration/zuul/index.html
+++ b/org/wikimedia/integration/zuul/index.html
@@ -5,68 +5,75 @@
        <title>Zuul status page - Wikimedia</title>
        <meta name="viewport" content="width=device-width, initial-scale=1.0">
        <link rel="shortcut icon" href="//bits.wikimedia.org/favicon/wmf.ico">
-       <link rel="stylesheet" href="/bootstrap/css/bootstrap.min.css">
-       <link rel="stylesheet" 
href="/bootstrap/css/bootstrap-responsive.min.css">
+       <link rel="stylesheet" href="../bootstrap/css/bootstrap.min.css">
+       <link rel="stylesheet" 
href="../bootstrap/css/bootstrap-responsive.min.css">
+       <style>
+       .change {
+               border: 1px solid #95c7db;
+               margin-top: 10px;
+               padding: 2px;
+       }
 
-       <style type="text/css">
-               #pipeline-container {
-                       max-width: 950px;
-                       margin: 0 auto;
-               }
-               .change {
-                       border: 1px solid #95c7db;
-                       margin-top: 10px;
-                       padding: 2px;
-               }
-               .change > .header {
-                       background: #E2ECEF;
-                       color: black;
-                       margin: -2px -2px 2px -2px;
-                       padding: 4px;
-               }
-               .change > .header > .changeid {
-                       float: right;
-               }
-               .job {
-                       display: block;
-               }
-               .pipeline {
-                       float: left;
-                       width: 25em;
-                       padding: 4px;
-               }
-               .pipeline > .header {
-                       background: #0000cc;
-                       color: white;
-               }
-               .arrow {
-                       text-align: center;
-                       font-size: 16pt;
-                       line-height: 1.0;
-               }
-               .result_success {
-                       color: #007f00;
-               }
-               .result_failure {
-                       color: #cf2f19;
-               }
-               .result_unstable {
-                       color: #e39f00;
-               }
-               a:link {
-                       color: #204A87;
-               }
-               #message p{
-                       margin: 0;
-               }
-               .alertbox {
-                       border: 1px solid #e5574d;
-                       background: #ffaba5;
-                       color: black;
-                       padding: 1em;
-                       font-size: 12pt;
-                       margin: 0pt;
-               }
+       .change > .header {
+               background: #E2ECEF;
+               color: black;
+               margin: -2px -2px 2px -2px;
+               padding: 4px;
+       }
+
+       .change > .header > .changeid {
+               float: right;
+       }
+
+       .job {
+               display: block;
+       }
+
+       .pipeline {
+               float: left;
+               width: 25em;
+               padding: 4px;
+       }
+
+       .pipeline > .header {
+               background: #0000cc;
+               color: white;
+       }
+
+       .arrow {
+               text-align: center;
+               font-size: 16pt;
+               line-height: 1.0;
+       }
+
+       .result_success {
+               color: #007f00;
+       }
+
+       .result_failure {
+               color: #cf2f19;
+       }
+
+       .result_unstable {
+               color: #e39f00;
+       }
+
+       a:link {
+               color: #204A87;
+       }
+
+       #message p {
+               margin: 0;
+       }
+
+       .alertbox {
+               border: 1px solid #e5574d;
+               background: #ffaba5;
+               color: black;
+               padding: 1em;
+               font-size: 12pt;
+               margin: 0pt;
+       }
        </style>
 </head>
 <body>
@@ -74,8 +81,8 @@
                <div class="container">
                        <div class="page-header">
                                <a href="//www.wikimediafoundation.org/">
-                                       <img 
src="//upload.wikimedia.org/wikipedia/foundation/9/9a/Wikimediafoundation-logo.png"
-                                       width="135" height="135" alt="MediaWiki 
logo" class="logo pull-right">
+                               <img 
src="//upload.wikimedia.org/wikipedia/foundation/9/9a/Wikimediafoundation-logo.png"
+                                       width="135" height="135" alt="Wikimedia 
Foundation logo" class="logo pull-right">
                                </a>
                                <h2>Zuul status page</h2>
                        </div>
@@ -86,13 +93,12 @@
                        <span id="result_event_queue_length"></span> 
results.</p>
 
                        <div class="container">
-                               <div id="message"/>
+                               <div id="message"></div>
                        </div>
 
-                       <div id="pipeline-container">
-                       </div>
+                       <div id="pipeline-container"></div>
 
-                       <!-- TODO: add graphite :-]
+                       <!-- TODO: add graphite
                        <div class="container" id="graph-container">
                                <h2>Job statistics</h2>
                        </div>
@@ -101,7 +107,7 @@
        </div><!-- /.page-wrap -->
 
        <script 
src="//bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&amp;modules=jquery&amp;only=scripts&amp;raw=1"></script>
-       <script src="/bootstrap/js/bootstrap.min.js"></script>
+       <script src="../bootstrap/js/bootstrap.min.js"></script>
        <script src="status.js"></script>
 </body>
 </html>

-- 
To view, visit https://gerrit.wikimedia.org/r/54887
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0ddc7ceb56ebbb230c463a0367c5c454151bad1b
Gerrit-PatchSet: 1
Gerrit-Project: integration/docroot
Gerrit-Branch: master
Gerrit-Owner: Krinkle <ttij...@wikimedia.org>
Gerrit-Reviewer: Krinkle <ttij...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to