jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/378767 )
Change subject: WLFilters: always create a balanced fieldset
......................................................................
WLFilters: always create a balanced fieldset
Don't count on Xml::fieldset creating only the opening tag.
Bug: T176155
Change-Id: Idc4e450c9fa03fc78a012fb5eefa60174bb1245a
---
M includes/specials/SpecialWatchlist.php
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialWatchlist.php
b/includes/specials/SpecialWatchlist.php
index 2750551..8418865 100644
--- a/includes/specials/SpecialWatchlist.php
+++ b/includes/specials/SpecialWatchlist.php
@@ -635,11 +635,13 @@
'id' => 'mw-watchlist-form'
] );
$form .= Html::hidden( 'title',
$this->getPageTitle()->getPrefixedText() );
- $form .= Xml::fieldset(
- $this->msg( 'watchlist-options' )->text(),
- false,
+ $form .= Xml::openElement(
+ 'fieldset',
[ 'id' => 'mw-watchlist-options', 'class' =>
'cloptions' ]
);
+ $form .= Xml::element(
+ 'legend', null, $this->msg( 'watchlist-options'
)->text()
+ );
if ( !$this->isStructuredFilterUiEnabled() ) {
$form .= $this->makeLegend();
--
To view, visit https://gerrit.wikimedia.org/r/378767
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc4e450c9fa03fc78a012fb5eefa60174bb1245a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Sbisson <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
