jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/378375 )

Change subject: Remove Content-Length from PDF response
......................................................................


Remove Content-Length from PDF response

Seems to interact poorly with Varnish.

Bug: T175868
Change-Id: I169304f1a2e1ec3b5bfe1549bcd2ecb96974953e
---
M includes/BookRenderingMediator.php
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Pmiazga: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/BookRenderingMediator.php 
b/includes/BookRenderingMediator.php
index d664940..bf37b79 100644
--- a/includes/BookRenderingMediator.php
+++ b/includes/BookRenderingMediator.php
@@ -165,7 +165,6 @@
                $mediawikiResponse->statusHeader( 200 );
                $mediawikiResponse->header( 'Content-Type: application/pdf' );
                $mediawikiResponse->header( "Content-Disposition: attachment; 
filename='book.pdf'" );
-               $mediawikiResponse->header( 'Content-Length: ' . strlen( 
$newPdfContent ) );
                echo $newPdfContent;
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/378375
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I169304f1a2e1ec3b5bfe1549bcd2ecb96974953e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Collection
Gerrit-Branch: master
Gerrit-Owner: GergÅ‘ Tisza <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: C. Scott Ananian <[email protected]>
Gerrit-Reviewer: Pmiazga <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to