[MediaWiki-commits] [Gerrit] mediawiki...Collection[wmf/1.30.0-wmf.18]: Fix cache key generation

[Code Review]

Gergő Tisza has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/378826 )

Change subject: Fix cache key generation
......................................................................

Fix cache key generation

Change-Id: Ie07199e3d4cab06379870249acbec5e01d741449
---
M includes/BookRenderingMediator.php
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Collection 
refs/changes/26/378826/1

diff --git a/includes/BookRenderingMediator.php 
b/includes/BookRenderingMediator.php
index bf37b79..9d30550 100644
--- a/includes/BookRenderingMediator.php
+++ b/includes/BookRenderingMediator.php
@@ -90,9 +90,11 @@
                $keyBase = wfArrayFilterByKey( $collection, function ( $key ) {
                        return in_array( $key, [ 'title', 'subtitle', 'items' 
], true );
                } );
-               $keyBase['items'] = wfArrayFilterByKey( $keyBase['items'], 
function ( $key ) {
-                       return in_array( $key, [ 'type', 'title', 'revision' ], 
true );
-               } );
+               $keyBase['items'] = array_map( function ( $item ) {
+                       return wfArrayFilterByKey( $item, function ( $key ) {
+                               return in_array( $key, [ 'type', 'title', 
'revision' ], true );
+                       } );
+               }, $keyBase['items'] );
                $key = $this->htmlCache->makeGlobalKey( md5( json_encode( 
$keyBase ) ) );
 
                $book = $this->htmlCache->get( $key );

-- 
To view, visit https://gerrit.wikimedia.org/r/378826
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie07199e3d4cab06379870249acbec5e01d741449
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Collection
Gerrit-Branch: wmf/1.30.0-wmf.18
Gerrit-Owner: Gergő Tisza <gti...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits