jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/378901 )
Change subject: Chore: Set target value for src/common ts files
......................................................................
Chore: Set target value for src/common ts files
Nearest common ancestor is the root tsconfig, so by default we'll set
a modern target for common code, so that we don't get warnings (about
Promise usage for example) when using editors like vscode. We also set
the module to commonjs to avoid dynamic import warnings, and allow
webpack.config.ts to keep working fine.
The entry points, src/{client,server} have their own tsconfig with
different targets, so errors related to the target for their specific
environments will be reported when compiling specifically the client or
server code.
Change-Id: Ib07d51cb6f52bba6e8359ec3c1f74e1477c1a514
---
M tsconfig.json
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Niedzielski: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tsconfig.json b/tsconfig.json
index 4d3ea6e..63935b1 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -9,6 +9,8 @@
"src/common"
],
"compilerOptions": {
+ "target": "ES2017",
+ "module": "commonjs",
"jsx": "react",
"jsxFactory": "h",
"moduleResolution": "node",
--
To view, visit https://gerrit.wikimedia.org/r/378901
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib07d51cb6f52bba6e8359ec3c1f74e1477c1a514
Gerrit-PatchSet: 2
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Jhernandez <[email protected]>
Gerrit-Reviewer: Jhernandez <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
